Skip to content

Commit 8fe344e

Browse files
prepping for 0.5
1 parent 6f87c24 commit 8fe344e

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/esruntimebuilder.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use crate::esruntime::{EsRuntime, ModuleCodeLoader};
22
use crate::esruntimeinner::EsRuntimeInner;
33
use std::time::Duration;
44

5-
/// The EsRuntimeWrapperBuilder struct can be used to initialize a new EsRuntimeWrapper
5+
/// The EsRuntimeBuilder struct can be used to initialize a new EsRuntime
66
///
77
/// # Example
88
///
@@ -22,7 +22,7 @@ pub struct EsRuntimeBuilder {
2222
}
2323

2424
impl EsRuntimeBuilder {
25-
/// create a new instance of a EsRuntimeWrapperBuilder with it's default options
25+
/// create a new instance of a EsRuntimeBuilder with it's default options
2626
pub fn new() -> Self {
2727
EsRuntimeBuilder {
2828
gc_interval: None,
@@ -51,7 +51,7 @@ impl EsRuntimeBuilder {
5151
self
5252
}
5353

54-
/// build a new EsRuntimeWrapper based on the settings of this builder
54+
/// build a new EsRuntime based on the settings of this builder
5555
/// please note that this can be used only once
5656
pub fn build(&mut self) -> EsRuntime {
5757
if self.built {
@@ -69,10 +69,10 @@ impl EsRuntimeBuilder {
6969
};
7070

7171
let inner = EsRuntimeInner::build(mcl_opt, self.module_cache_size);
72-
let wrapper = EsRuntime::new_inner(inner);
72+
let es_rt = EsRuntime::new_inner(inner);
7373
if self.gc_interval.is_some() {
74-
wrapper.start_gc_deamon(self.gc_interval.unwrap());
74+
es_rt.start_gc_deamon(self.gc_interval.unwrap());
7575
}
76-
wrapper
76+
es_rt
7777
}
7878
}

src/jsapi_utils/promises.rs

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ pub fn object_is_promise(obj: HandleObject) -> bool {
2222
object_is_promise_raw(obj.into())
2323
}
2424

25+
/// return true if the given JSVal is a Promise
2526
pub fn value_is_promise(val: HandleValue) -> bool {
2627
if val.is_object() {
2728
let obj: *mut JSObject = val.to_object();

0 commit comments

Comments
 (0)