New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdt: wrong macro name #26

Open

ohk990102 opened this issue Jul 9, 2020 · 1 comment

Collaborator

ohk990102 commented Jul 9, 2020 •

edited

Loading

https://github.com/hhro/lets_make_kernel/blob/df8f5ce5e890fb417aa8d1c5136a8e3e7b377c16/arch/x86/include/kapi/gdt.hpp#L4-L4

https://github.com/hhro/lets_make_kernel/blob/7c1c8bab15a2db3bfd52cefce8abeef8dfb19207/arch/x86/boot/boot.S#L99-L99

이거 macro가 GDT_ENTRY_SIZE가 아니라 GDT_KERNEL_CODE_SEGMENT 이런식으로 하는게 맞을거같음.

The text was updated successfully, but these errors were encountered:

Collaborator Author

ohk990102 commented Jul 9, 2020 •

edited

Loading

다시 생각해보니 https://github.com/hhro/lets_make_kernel/blob/7c1c8bab15a2db3bfd52cefce8abeef8dfb19207/arch/x86/boot/boot.S#L99-L99 걍 이부분에 GDT_ENTRY_SIZE를 쓰는게 좀 이상함

GDT_ENTRY_SIZE 외에도 GDT_KERNEL_CODE_SEGMENT 랑 GDT_KERNEL_DATA_SEGMENT 매크로를 만들어서 쓰는게 좋을듯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment