Skip to content

Commit 607560d

Browse files
Disable video recording in Windows due to ffmpeg crash (opensearch-project#1069)
* Disable video recording in Windows due to ffmpeg crash Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
1 parent 2f5d2f0 commit 607560d

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

integtest.sh

+9-2
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ if [[ $REMOTE_CYPRESS_ENABLED = "true" && $ORCHESTRATOR_FEATURE_FLAG = 'true' ]
202202

203203
# Delete the temporary log files and folder after writing to CI
204204
rm -rf "$log_directory"
205+
rm "$pid_file"
205206
fi
206-
rm "$pid_file"
207207

208208
## WARNING: THIS LOGIC NEEDS TO BE THE LAST IN THIS FILE! ##
209209
# Cypress returns back the test failure count in the error code
@@ -212,7 +212,14 @@ rm "$pid_file"
212212
# We need to ensure the cypress tests are the last execute process to
213213
# the error code gets passed to the CI.
214214

215-
if [ $SECURITY_ENABLED = "true" ]; then
215+
if [ "$OSTYPE" = "msys" ] || [ "$OSTYPE" = "cygwin" ] || [ "$OSTYPE" = "win32" ]; then
216+
echo "Disable video recording in Windows due to ffmpeg missing libs in Windows Docker Container"
217+
echo "TODO: https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/1068"
218+
jq '. + {"video": false}' cypress.json > cypress_new.json # jq does not allow reading and writing on same file
219+
mv -v cypress_new.json cypress.json
220+
fi
221+
222+
if [ "$SECURITY_ENABLED" = "true" ]; then
216223
echo "Running security enabled tests"
217224
yarn cypress:run-with-security --browser "$BROWSER_PATH" --spec "$TEST_FILES"
218225
else

0 commit comments

Comments
 (0)