You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Serene Seasons and Distant Horizons don't play well with each other at the moment. This is due to LODs from Distant Horizons not reloading on season change (can be trivially implemented by using the DH API in Serene Seasons), and DH not being aware of grass and foliage color changes from Serene Seasons.
How can the issue be reproduced?
Launch the game with the following mods:
[✔] DistantHorizons-2.2.1-a-1.21.1-neo-fabric
[✔] fabric-api-0.115.0+1.21.1
[✔] GlitchCore-fabric-1.21.1-2.1.0.0
[✔] SereneSeasons-fabric-1.21.1-10.1.0.1
Set render distance to 8 to see the LODs more easily
Load into a world and teleport to the nearest birch forest /locate biome minecraft:birch_forest
Move away from the birch forest far enough that it gets turned into LODs
Set the season to early winter /season set early_winter. Observe that the LODs are unaffected since they do not reload on season change
Exit into the main menu, then load back into the world. Observe that the birch leaves color got updated to match the season, but not the grass or foliage color
The issue where the LODs don't reload on season change can be fixed trivially by using the DH API. Inserting
DhApi.Delayed.renderProxy.clearRenderDataCache();
after the allChanged() call in the section below will cause the LODs to reload on the spot after a season change, without having to exit and load back into the world.
This does not fix the other issue where DH seems to only be aware of the birch leaves color change and not the grass or foliage color changes. The cause of this issue is unknown to me.
The text was updated successfully, but these errors were encountered:
What's the issue you encountered?
Serene Seasons and Distant Horizons don't play well with each other at the moment. This is due to LODs from Distant Horizons not reloading on season change (can be trivially implemented by using the DH API in Serene Seasons), and DH not being aware of grass and foliage color changes from Serene Seasons.
How can the issue be reproduced?
[✔] DistantHorizons-2.2.1-a-1.21.1-neo-fabric
[✔] fabric-api-0.115.0+1.21.1
[✔] GlitchCore-fabric-1.21.1-2.1.0.0
[✔] SereneSeasons-fabric-1.21.1-10.1.0.1
/locate biome minecraft:birch_forest
/season set early_winter
. Observe that the LODs are unaffected since they do not reload on season changeLogs
https://mclo.gs/iE6pHlK
Mod Version
fabric-1.21.1-10.1.0.1
Additional information
The issue where the LODs don't reload on season change can be fixed trivially by using the DH API. Inserting
DhApi.Delayed.renderProxy.clearRenderDataCache();
after the
allChanged()
call in the section below will cause the LODs to reload on the spot after a season change, without having to exit and load back into the world.SereneSeasons/common/src/main/java/sereneseasons/season/SeasonHandlerClient.java
Lines 36 to 40 in 6fa30b8
This does not fix the other issue where DH seems to only be aware of the birch leaves color change and not the grass or foliage color changes. The cause of this issue is unknown to me.
The text was updated successfully, but these errors were encountered: