Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distant Horizons compatibility #530

Open
pajicadvance opened this issue Feb 17, 2025 · 0 comments
Open

Distant Horizons compatibility #530

pajicadvance opened this issue Feb 17, 2025 · 0 comments

Comments

@pajicadvance
Copy link

pajicadvance commented Feb 17, 2025

What's the issue you encountered?

Serene Seasons and Distant Horizons don't play well with each other at the moment. This is due to LODs from Distant Horizons not reloading on season change (can be trivially implemented by using the DH API in Serene Seasons), and DH not being aware of grass and foliage color changes from Serene Seasons.

How can the issue be reproduced?

  1. Launch the game with the following mods:
    [✔] DistantHorizons-2.2.1-a-1.21.1-neo-fabric
    [✔] fabric-api-0.115.0+1.21.1
    [✔] GlitchCore-fabric-1.21.1-2.1.0.0
    [✔] SereneSeasons-fabric-1.21.1-10.1.0.1
  2. Set render distance to 8 to see the LODs more easily
  3. Load into a world and teleport to the nearest birch forest /locate biome minecraft:birch_forest
  4. Move away from the birch forest far enough that it gets turned into LODs

Image

  1. Set the season to early winter /season set early_winter. Observe that the LODs are unaffected since they do not reload on season change

Image

  1. Exit into the main menu, then load back into the world. Observe that the birch leaves color got updated to match the season, but not the grass or foliage color

Image

Logs

https://mclo.gs/iE6pHlK

Mod Version

fabric-1.21.1-10.1.0.1

Additional information

The issue where the LODs don't reload on season change can be fixed trivially by using the DH API. Inserting

DhApi.Delayed.renderProxy.clearRenderDataCache();

after the allChanged() call in the section below will cause the LODs to reload on the spot after a season change, without having to exit and load back into the world.

if (calendar.getSubSeason() != lastSeason)
{
Minecraft.getInstance().levelRenderer.allChanged();
lastSeason = calendar.getSubSeason();
}

This does not fix the other issue where DH seems to only be aware of the birch leaves color change and not the grass or foliage color changes. The cause of this issue is unknown to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant