[IMP] coupon_incompatibility, sale_coupon_incompatibility

Allow coupon_incompatibility settings to be used by other modules.

Author: stefan-tecnativa

sale_loyalty_incompatibility/README.rst

@@ -2,10 +2,13 @@
 Coupon incompatibilities
 ========================
 
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:5f10374003403bbcd364cf5e67d597e54a8528030be49132d4fda54d30f4df16
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Production%2FStable-green.png
     :target: https://odoo-community.org/page/development-status
@@ -14,16 +17,16 @@ Coupon incompatibilities
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--promotion-lightgray.png?logo=github
-    :target: https://github.com/OCA/sale-promotion/tree/13.0/sale_coupon_incompatibility
+    :target: https://github.com/OCA/sale-promotion/tree/15.0/sale_coupon_incompatibility
     :alt: OCA/sale-promotion
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/sale-promotion-13-0/sale-promotion-13-0-sale_coupon_incompatibility
+    :target: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_incompatibility
     :alt: Translate me on Weblate
-.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/296/13.0
-    :alt: Try me on Runbot
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-promotion&target_branch=15.0
+    :alt: Try me on Runboat
 
-|badge1| |badge2| |badge3| |badge4| |badge5| 
+|badge1| |badge2| |badge3| |badge4| |badge5|
 
 This module allows to set incompatibilities between promotions, so when a promotion A
 is not compatible with promotion B, they can't be applied together in a sales order.
@@ -33,17 +36,6 @@ is not compatible with promotion B, they can't be applied together in a sales or
 .. contents::
    :local:
 
-Configuration
-=============
-
-To configure promotion incompatibilities (either coupons or promotion programs):
-
-#. Go to *Sales > Catalog > Coupon Programs* and select or create a new one.
-#. In the *Incompatible Promotions* set the promotions that aren't compatible with the
-   one you're configuring.
-#. Once set, the those promotions will have your configured promotion as incompatible
-   as well, so they can't be used altogether in the same sale order.
-
 Usage
 =====
 
@@ -58,8 +50,8 @@ Bug Tracker
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-promotion/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/sale-promotion/issues/new?body=module:%20sale_coupon_incompatibility%0Aversion:%2013.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/sale-promotion/issues/new?body=module:%20sale_coupon_incompatibility%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -78,6 +70,7 @@ Contributors
 
   * Pedro M. Baeza
   * David Vidal
+  * Stefan Ungureanu
 
 Maintainers
 ~~~~~~~~~~~
@@ -100,6 +93,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-chienandalu| 
 
-This module is part of the `OCA/sale-promotion <https://github.com/OCA/sale-promotion/tree/13.0/sale_coupon_incompatibility>`_ project on GitHub.
+This module is part of the `OCA/sale-promotion <https://github.com/OCA/sale-promotion/tree/15.0/sale_coupon_incompatibility>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_loyalty_incompatibility/__manifest__.py

@@ -10,6 +10,5 @@
     "author": "Tecnativa, Odoo Community Association (OCA)",
     "maintainers": ["chienandalu"],
     "license": "AGPL-3",
-    "depends": ["sale_coupon"],
-    "data": ["views/sale_coupon_program_views.xml"],
+    "depends": ["sale_coupon", "coupon_incompatibility"],
 }

sale_loyalty_incompatibility/i18n/es.po

@@ -0,0 +1,42 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_coupon_incompatibility
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 15.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2023-02-02 10:28+0000\n"
+"PO-Revision-Date: 2023-02-02 11:30+0100\n"
+"Last-Translator: \n"
+"Language-Team: \n"
+"Language: es_ES\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Generator: Poedit 3.2.2\n"
+
+#. module: sale_coupon_incompatibility
+#: model:ir.model,name:sale_coupon_incompatibility.model_coupon_coupon
+msgid "Coupon"
+msgstr "Cupón"
+
+#. module: sale_coupon_incompatibility
+#: model:ir.model,name:sale_coupon_incompatibility.model_coupon_program
+msgid "Coupon display on a website"
+msgstr ""
+
+#. module: sale_coupon_incompatibility
+#: code:addons/sale_coupon_incompatibility/models/coupon_program.py:0
+#: code:addons/sale_coupon_incompatibility/models/sale_coupon.py:0
+#, python-format
+msgid ""
+"This promotion is incompatible with other set already in the order so it "
+"can't be applied."
+msgstr ""
+"Esta promoción es incompatible con otra ya presente en la orden por lo que "
+"no se puede aplicar."
+
+#~ msgid "Coupon Program"
+#~ msgstr "Programa de cupones"

sale_loyalty_incompatibility/i18n/sale_coupon_incompatibility.pot

@@ -4,7 +4,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 13.0\n"
+"Project-Id-Version: Odoo Server 15.0\n"
 "Report-Msgid-Bugs-To: \n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -14,23 +14,18 @@ msgstr ""
 "Plural-Forms: \n"
 
 #. module: sale_coupon_incompatibility
-#: model:ir.model.fields,field_description:sale_coupon_incompatibility.field_sale_coupon_program__incompatible_promotion_ids
-msgid "Incompatible Promotions"
+#: model:ir.model,name:sale_coupon_incompatibility.model_coupon_coupon
+msgid "Coupon"
 msgstr ""
 
 #. module: sale_coupon_incompatibility
-#: model:ir.model,name:sale_coupon_incompatibility.model_sale_coupon
-msgid "Sales Coupon"
-msgstr ""
-
-#. module: sale_coupon_incompatibility
-#: model:ir.model,name:sale_coupon_incompatibility.model_sale_coupon_program
-msgid "Sales Coupon Program"
+#: model:ir.model,name:sale_coupon_incompatibility.model_coupon_program
+msgid "Coupon display on a website"
 msgstr ""
 
 #. module: sale_coupon_incompatibility
+#: code:addons/sale_coupon_incompatibility/models/coupon_program.py:0
 #: code:addons/sale_coupon_incompatibility/models/sale_coupon.py:0
-#: code:addons/sale_coupon_incompatibility/models/sale_coupon_program.py:0
 #, python-format
 msgid ""
 "This promotion is incompatible with other set already in the order so it "

sale_loyalty_incompatibility/models/__init__.py

@@ -1,2 +1,2 @@
-from . import sale_coupon_program
+from . import coupon_program
 from . import sale_coupon

sale_loyalty_incompatibility/models/coupon_program.py

@@ -0,0 +1,27 @@
+# Copyright 2021 Tecnativa - David Vidal
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import _, models
+
+
+class CouponProgram(models.Model):
+    _inherit = "coupon.program"
+
+    def _check_promo_code(self, order, coupon_code):
+        """Promotion incompatibility rules. Check the error strings for a detailed case
+        detail."""
+        message = super()._check_promo_code(order, coupon_code)
+        # Other errors may precede
+        if message:
+            return message
+        order_programs = order.no_code_promo_program_ids + order.code_promo_program_id
+        order_programs |= (
+            order.applied_coupon_ids + order.generated_coupon_ids
+        ).mapped("program_id")
+        if any({x in order_programs for x in self.incompatible_promotion_ids}):
+            message = {
+                "error": _(
+                    "This promotion is incompatible with other set already in the "
+                    "order so it can't be applied."
+                )
+            }
+        return message

sale_loyalty_incompatibility/models/sale_coupon.py

@@ -3,14 +3,14 @@
 from odoo import _, models
 
 
-class SaleCoupon(models.Model):
+class Coupon(models.Model):
     _inherit = "coupon.coupon"
 
     def _check_coupon_code(self, order_date, partner_id, **kwargs):
         """Coupon incompatibility rules. Check the error strings for a detailed case
         detail."""
-        order = kwargs.get("order", False)
         message = super()._check_coupon_code(order_date, partner_id, **kwargs)
+        order = kwargs.get("order", False)
         # Other errors may precede
         if message:
             return message