Skip to content

Commit 19cf08c

Browse files
andrrossshiv0408
authored andcommitted
Remove unused segment replication feature flag (opensearch-project#11850)
This feature has been released and the feature flag is no longer used. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
1 parent 12fb0e5 commit 19cf08c

File tree

2 files changed

+7
-27
lines changed

2 files changed

+7
-27
lines changed

server/src/main/java/org/opensearch/common/settings/FeatureFlagSettings.java

+7-15
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
import org.opensearch.common.settings.Setting.Property;
1212
import org.opensearch.common.util.FeatureFlags;
1313

14-
import java.util.Arrays;
15-
import java.util.Collections;
16-
import java.util.HashSet;
1714
import java.util.Set;
1815

1916
/**
@@ -32,17 +29,12 @@ protected FeatureFlagSettings(
3229
super(settings, settingsSet, settingUpgraders, scope);
3330
}
3431

35-
public static final Set<Setting<?>> BUILT_IN_FEATURE_FLAGS = Collections.unmodifiableSet(
36-
new HashSet<>(
37-
Arrays.asList(
38-
FeatureFlags.SEGMENT_REPLICATION_EXPERIMENTAL_SETTING,
39-
FeatureFlags.EXTENSIONS_SETTING,
40-
FeatureFlags.IDENTITY_SETTING,
41-
FeatureFlags.CONCURRENT_SEGMENT_SEARCH_SETTING,
42-
FeatureFlags.TELEMETRY_SETTING,
43-
FeatureFlags.DATETIME_FORMATTER_CACHING_SETTING,
44-
FeatureFlags.WRITEABLE_REMOTE_INDEX_SETTING
45-
)
46-
)
32+
public static final Set<Setting<?>> BUILT_IN_FEATURE_FLAGS = Set.of(
33+
FeatureFlags.EXTENSIONS_SETTING,
34+
FeatureFlags.IDENTITY_SETTING,
35+
FeatureFlags.CONCURRENT_SEGMENT_SEARCH_SETTING,
36+
FeatureFlags.TELEMETRY_SETTING,
37+
FeatureFlags.DATETIME_FORMATTER_CACHING_SETTING,
38+
FeatureFlags.WRITEABLE_REMOTE_INDEX_SETTING
4739
);
4840
}

server/src/main/java/org/opensearch/common/util/FeatureFlags.java

-12
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@
2020
* @opensearch.internal
2121
*/
2222
public class FeatureFlags {
23-
/**
24-
* Gates the visibility of the segment replication experimental features that allows users to test unreleased beta features.
25-
*/
26-
public static final String SEGMENT_REPLICATION_EXPERIMENTAL =
27-
"opensearch.experimental.feature.segment_replication_experimental.enabled";
28-
2923
/**
3024
* Gates the ability for Searchable Snapshots to read snapshots that are older than the
3125
* guaranteed backward compatibility for OpenSearch (one prior major version) on a best effort basis.
@@ -105,12 +99,6 @@ public static boolean isEnabled(Setting<Boolean> featureFlag) {
10599
}
106100
}
107101

108-
public static final Setting<Boolean> SEGMENT_REPLICATION_EXPERIMENTAL_SETTING = Setting.boolSetting(
109-
SEGMENT_REPLICATION_EXPERIMENTAL,
110-
false,
111-
Property.NodeScope
112-
);
113-
114102
public static final Setting<Boolean> EXTENSIONS_SETTING = Setting.boolSetting(EXTENSIONS, false, Property.NodeScope);
115103

116104
public static final Setting<Boolean> IDENTITY_SETTING = Setting.boolSetting(IDENTITY, false, Property.NodeScope);

0 commit comments

Comments
 (0)