Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot optionally depend on the culling API #285

Open
hlysine opened this issue Aug 29, 2024 · 5 comments
Open

Cannot optionally depend on the culling API #285

hlysine opened this issue Aug 29, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation suggestion A suggestion, enhancement, feature or request TODO This is good and just needs to be implemented

Comments

@hlysine
Copy link

hlysine commented Aug 29, 2024

Hi, Create: Copycats+ dev here. We have received reports of this mod being incompatible with Copycats+, so I'm trying to implement compat by disabling culling for all our copycats (we already have advanced culling implemented in the block model, so culling done by this mod is redundant). However, because all of MoreCulling's API requires our blocks to implement an interface, I don't think it is possible to optionally depend on this mod, which makes the API unusable since we cannot force all users to download this mod.

Is it possible for other mods to opt out of MoreCulling using something more compatible (e.g. tags)?

@FxMorin
Copy link
Owner

FxMorin commented Sep 21, 2024

There are a couple ways: https://github.com/fxmorin/MoreCulling/wiki/Using-the-API
Including a tag or config

@hlysine
Copy link
Author

hlysine commented Sep 22, 2024

I need a tag that disables More Culling in general, since our copycat blocks are neither leaves nor doors.

@FxMorin
Copy link
Owner

FxMorin commented Sep 23, 2024

dont_cull is a tag which does that

@FxMorin
Copy link
Owner

FxMorin commented Sep 27, 2024

Reminder: List all ways for other mod devs to optionally depend on the culling API

@FxMorin FxMorin added suggestion A suggestion, enhancement, feature or request TODO This is good and just needs to be implemented documentation Improvements or additions to documentation labels Sep 27, 2024
@ChiefArug
Copy link

It is also possible to conditionally self mixin the interface in, although its a bit messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation suggestion A suggestion, enhancement, feature or request TODO This is good and just needs to be implemented
Projects
None yet
Development

No branches or pull requests

3 participants