Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize water and lava by making them more bumpy #254

Open
muzikbike opened this issue Jun 6, 2024 · 1 comment
Open

Optimize water and lava by making them more bumpy #254

muzikbike opened this issue Jun 6, 2024 · 1 comment
Labels
suggestion A suggestion, enhancement, feature or request

Comments

@muzikbike
Copy link

I originally suggested this for Sodium (CaffeineMC/sodium#2472), but it ended up being rejected, so it might fit better here.

Basically, the idea is: if a block with a full bottom face exists above water or lava, then the fluid height would raise such that it would be coplanar with the underside of said block. Here's a comparison:
2024-06-06_00 28 22
2024-06-06_00 28 23

Since this would end up with the face 100% obscured if the block above is opaque, we could then cull it. This would eliminate lots of unneeded geometry in the Nether and above water caves, and things would also look a lot nicer from above and within the fluid as well (refer to the linked ticket for examples).

The fluid height would still snap up to full transparent blocks such as glass, but would not cull.

@FxMorin
Copy link
Owner

FxMorin commented Jun 7, 2024

Thats not a terrible idea. It's a little complicated, since it would require me to change the hardcoded geometry.
Not sure if I have the time to do it either, so we will see.

@FxMorin FxMorin added the suggestion A suggestion, enhancement, feature or request label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion, enhancement, feature or request
Projects
None yet
Development

No branches or pull requests

2 participants