Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing how blocks interact with water #158

Open
muzikbike opened this issue Apr 22, 2023 · 1 comment
Open

Changing how blocks interact with water #158

muzikbike opened this issue Apr 22, 2023 · 1 comment
Labels
suggestion A suggestion, enhancement, feature or request

Comments

@muzikbike
Copy link

I'm not sure if this would fit better in here or in Extra, but it seems relevant enough (unwanted faces would be culled if this was implemented).

Here's two glass blocks underwater compared with two beacons underwater:
2023-04-22_19 37 56

As you can see, the beacons have an undesirable flowing water texture coating them. Some way to get rid of this for select blocks like beacons through the mod might be a good idea.

Sodium appears to affect this since a lot more blocks (such as signs and barriers) cause the rendering type glass causes to be used instead of how vanilla acts: CaffeineMC/sodium#991 - I'm not sure if it'd be possible to have this mod revert those changes until a proper fix is implemented over there if both are installed at the same time.

@FxMorin
Copy link
Owner

FxMorin commented Jan 7, 2024

Water rendering code is a mess. Don't plan on touching it anytime soon, it has lots of conditions

@FxMorin FxMorin added the suggestion A suggestion, enhancement, feature or request label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion, enhancement, feature or request
Projects
None yet
Development

No branches or pull requests

2 participants