refactor: forc init generate unexpected project_name when project dir contains dot (#5455)

## Description
Refer #5434

Found this issue when I tried to run `forc init --script` under a
directory(`/tmp/path_with_._dot`) that contains a dot ".". The value of
`project.name` in the generated file `Forc.toml` is truncated by the dot
"." as `path_with_`.

Since `project_dir` must be a directory(has checked before), we can use
`file_name` instead of `file_stem` to get the last-level dir name. Also,
I think it would be better to replace "." with "_", otherwise a
`project_name` that contains `.` would fail with validation
`validate_name(&project_name, "project name")?;`

## Screenshots

#### Before:

![image](https://github.com/FuelLabs/sway/assets/25278203/b6073a20-81ea-45cb-9b58-842e43cb3257)

#### After:

![image](https://github.com/FuelLabs/sway/assets/25278203/4c48fffd-8da6-473c-b738-1ab2721dd53b)


## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>

Author: Halimao

forc-pkg/src/manifest/mod.rs

@@ -3,7 +3,7 @@ pub mod build_profile;
 use crate::pkg::{manifest_file_missing, parsing_failed, wrong_program_type};
 use anyhow::{anyhow, bail, Context, Result};
 use forc_tracing::println_warning;
-use forc_util::validate_name;
+use forc_util::{validate_name, validate_project_name};
 use serde::{Deserialize, Serialize};
 use serde_with::{serde_as, DisplayFromStr};
 use std::{
@@ -550,7 +550,7 @@ impl PackageManifest {
     /// 2. The validity of the details provided. Makes sure that there are no mismatching detail
     ///    declarations (to prevent mixing details specific to certain types).
     pub fn validate(&self) -> Result<()> {
-        validate_name(&self.project.name, "package name")?;
+        validate_project_name(&self.project.name)?;
         if let Some(ref org) = self.project.organization {
             validate_name(org, "organization name")?;
         }

forc-util/src/lib.rs

@@ -215,6 +215,11 @@ pub fn lock_path(manifest_dir: &Path) -> PathBuf {
     manifest_dir.join(constants::LOCK_FILE_NAME)
 }
 
+pub fn validate_project_name(name: &str) -> Result<()> {
+    restricted::is_valid_project_name_format(name)?;
+    validate_name(name, "project name")
+}
+
 // Using (https://github.com/rust-lang/cargo/blob/489b66f2e458404a10d7824194d3ded94bc1f4e4/src/cargo/util/toml/mod.rs +
 // https://github.com/rust-lang/cargo/blob/489b66f2e458404a10d7824194d3ded94bc1f4e4/src/cargo/ops/cargo_new.rs) for reference
 
@@ -223,17 +228,17 @@ pub fn validate_name(name: &str, use_case: &str) -> Result<()> {
     restricted::contains_invalid_char(name, use_case)?;
 
     if restricted::is_keyword(name) {
-        bail!("the name `{name}` cannot be used as a package name, it is a Sway keyword");
+        bail!("the name `{name}` cannot be used as a {use_case}, it is a Sway keyword");
     }
     if restricted::is_conflicting_artifact_name(name) {
         bail!(
-            "the name `{name}` cannot be used as a package name, \
+            "the name `{name}` cannot be used as a {use_case}, \
             it conflicts with Forc's build directory names"
         );
     }
     if name.to_lowercase() == "test" {
         bail!(
-            "the name `test` cannot be used as a project name, \
+            "the name `test` cannot be used as a {use_case}, \
             it conflicts with Sway's built-in test library"
         );
     }

forc-util/src/restricted.rs

@@ -2,6 +2,7 @@
 // This is based on https://github.com/rust-lang/cargo/blob/489b66f2e458404a10d7824194d3ded94bc1f4e4/src/cargo/util/restricted_names.rs
 
 use anyhow::{bail, Result};
+use regex::Regex;
 use std::path::Path;
 
 /// Returns `true` if the name contains non-ASCII characters.
@@ -94,6 +95,18 @@ pub fn is_glob_pattern<T: AsRef<str>>(name: T) -> bool {
     name.as_ref().contains(&['*', '?', '[', ']'][..])
 }
 
+/// Check the project name format.
+pub fn is_valid_project_name_format(name: &str) -> Result<()> {
+    let re = Regex::new(r"^([a-zA-Z]([a-zA-Z0-9-_]+)|)$").unwrap();
+    if !re.is_match(name) {
+        bail!(
+            "'{name}' is not a valid name for a project. \n\
+            The name may use letters, numbers, hyphens, and underscores, and must start with a letter."
+        );
+    }
+    Ok(())
+}
+
 #[test]
 fn test_invalid_char() {
     assert_eq!(
@@ -130,3 +143,35 @@ fn test_invalid_char() {
         std::result::Result::Ok(())
     ));
 }
+
+#[test]
+fn test_is_valid_project_name_format() {
+    let assert_valid = |name: &str| {
+        is_valid_project_name_format(name).expect("this should pass");
+    };
+
+    let assert_invalid = |name: &str, expected_error: &str| {
+        assert_eq!(
+            is_valid_project_name_format(name).map_err(|e| e.to_string()),
+            Err(expected_error.into())
+        );
+    };
+
+    let format_error_message = |name: &str| -> String {
+        format!(
+            "'{}' is not a valid name for a project. \n\
+            The name may use letters, numbers, hyphens, and underscores, and must start with a letter.",
+            name
+        )
+    };
+
+    // Test valid project names
+    assert_valid("mock_project_name");
+    assert_valid("mock_project_name123");
+    assert_valid("mock_project_name-123-_");
+
+    // Test invalid project names
+    assert_invalid("1mock_project", &format_error_message("1mock_project"));
+    assert_invalid("mock_.project", &format_error_message("mock_.project"));
+    assert_invalid("mock_/project", &format_error_message("mock_/project"));
+}

forc/src/cli/commands/new.rs

@@ -1,7 +1,7 @@
 use crate::{cli::init::Command as InitCommand, ops::forc_init::init};
 use anyhow::anyhow;
 use clap::Parser;
-use forc_util::{forc_result_bail, validate_name, ForcResult};
+use forc_util::{forc_result_bail, validate_project_name, ForcResult};
 use std::path::{Path, PathBuf};
 
 forc_util::cli_examples! {
@@ -55,7 +55,7 @@ pub(crate) fn exec(command: Command) -> ForcResult<()> {
     } = command;
 
     match &name {
-        Some(name) => validate_name(name, "project name")?,
+        Some(name) => validate_project_name(name)?,
         None => {
             // If there is no name specified for the project, the last component of the `path` (directory name)
             // will be used by default so we should also check that.
@@ -64,7 +64,7 @@ pub(crate) fn exec(command: Command) -> ForcResult<()> {
                 .file_name()
                 .ok_or_else(|| anyhow!("missing path for new command"))?
                 .to_string_lossy();
-            validate_name(&directory_name, "project_name")?;
+            validate_project_name(&directory_name)?;
         }
     }
 

forc/src/ops/forc_init.rs

@@ -1,7 +1,7 @@
 use crate::cli::InitCommand;
 use crate::utils::{defaults, program_type::ProgramType};
 use anyhow::Context;
-use forc_util::{forc_result_bail, validate_name, ForcResult};
+use forc_util::{forc_result_bail, validate_project_name, ForcResult};
 use std::fs;
 use std::io::Write;
 use std::path::{Path, PathBuf};
@@ -78,7 +78,7 @@ pub fn init(command: InitCommand) -> ForcResult<()> {
             .into_owned(),
     };
 
-    validate_name(&project_name, "project name")?;
+    validate_project_name(&project_name)?;
 
     let init_type = match (
         command.contract,

forc/src/ops/forc_template.rs

@@ -4,7 +4,7 @@ use forc_pkg::{
     manifest::{self, PackageManifest},
     source::{self, git::Url},
 };
-use forc_util::validate_name;
+use forc_util::validate_project_name;
 use fs_extra::dir::{copy, CopyOptions};
 use std::fs::File;
 use std::io::{Read, Write};
@@ -14,7 +14,7 @@ use sway_utils::constants;
 use tracing::info;
 
 pub fn init(command: TemplateCommand) -> Result<()> {
-    validate_name(&command.project_name, "project name")?;
+    validate_project_name(&command.project_name)?;
     // The name used for the temporary local repo directory used for fetching the template.
     let local_repo_name = command
         .template_name