Skip to content

Commit 461bebe

Browse files
authored
Remove warning comments (#5730)
## Description Removes comments added in #5704. The change setting None cases to true is actually correct and what we want. @danielbate
1 parent ddc420c commit 461bebe

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

sway-core/src/decl_engine/engine.rs

-10
Original file line numberDiff line numberDiff line change
@@ -190,23 +190,15 @@ macro_rules! decl_engine_clear_module {
190190
self.parents.write().unwrap().retain(|key, _| {
191191
match key {
192192
AssociatedItemDeclId::TraitFn(decl_id) => {
193-
// WARNING: Setting to true disables garbage collection for these cases.
194-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
195193
self.get_trait_fn(decl_id).span().source_id().map_or(true, |src_id| &src_id.module_id() != module_id)
196194
},
197195
AssociatedItemDeclId::Function(decl_id) => {
198-
// WARNING: Setting to true disables garbage collection for these cases.
199-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
200196
self.get_function(decl_id).span().source_id().map_or(true, |src_id| &src_id.module_id() != module_id)
201197
},
202198
AssociatedItemDeclId::Type(decl_id) => {
203-
// WARNING: Setting to true disables garbage collection for these cases.
204-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
205199
self.get_type(decl_id).span().source_id().map_or(true, |src_id| &src_id.module_id() != module_id)
206200
},
207201
AssociatedItemDeclId::Constant(decl_id) => {
208-
// WARNING: Setting to true disables garbage collection for these cases.
209-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
210202
self.get_constant(decl_id).span().source_id().map_or(true, |src_id| &src_id.module_id() != module_id)
211203
},
212204
}
@@ -215,8 +207,6 @@ macro_rules! decl_engine_clear_module {
215207
$(
216208
self.$slab.retain(|_k, ty| match ty.span().source_id() {
217209
Some(source_id) => &source_id.module_id() != module_id,
218-
// WARNING: Setting to true disables garbage collection for these cases.
219-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
220210
None => true,
221211
});
222212
)*

sway-core/src/decl_engine/parsed_engine.rs

-2
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,6 @@ macro_rules! decl_engine_clear_module {
142142
let span = $getter(item);
143143
match span.source_id() {
144144
Some(source_id) => &source_id.module_id() != module_id,
145-
// WARNING: Setting to true disables garbage collection for these cases.
146-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
147145
None => true,
148146
}
149147
});

sway-core/src/type_system/engine.rs

-4
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,13 @@ impl TypeEngine {
7272
pub fn clear_module(&mut self, module_id: &ModuleId) {
7373
self.slab.retain(|_, tsi| match tsi.source_id {
7474
Some(source_id) => &source_id.module_id() != module_id,
75-
// WARNING: Setting to true disables garbage collection for these cases.
76-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
7775
None => true,
7876
});
7977
self.id_map
8078
.write()
8179
.unwrap()
8280
.retain(|tsi, _| match tsi.source_id {
8381
Some(source_id) => &source_id.module_id() != module_id,
84-
// WARNING: Setting to true disables garbage collection for these cases.
85-
// This should be set back to false once this issue is solved: https://github.com/FuelLabs/sway/issues/5698
8682
None => true,
8783
});
8884
}

0 commit comments

Comments
 (0)