Skip to content

Commit dfeacd8

Browse files
authored
chore (#1834)
<!-- List the issues that this PR closes using a bullet list. For example: - Closes #X - Closes FE-Z --> <!-- # Summary Please provide a summary of your changes if they are not self-explanatory from the closed issues. In many cases, this section can be removed if the issues fully explain the reason for this PR. --> # Checklist - [ ] I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling) - [ ] I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes) - [ ] I've included the reference to the issues being closed from Github and/or Linear (or there was no issues) - [ ] I've changed the Docs to reflect my changes (or it was not needed) - [ ] I've put docs links where it may be helpful (or it was not needed) - [ ] I checked the resulting UI both in Light and Dark mode (or no UI changes were made) - [ ] I **reviewed** the **entire PR** myself (preferably, on GH UI)
1 parent 08370af commit dfeacd8

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

.github/workflows/release-npm-changeset.yaml

+8-7
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ env:
1414

1515
jobs:
1616
check-commit:
17-
name: Release master or rc
17+
name: Decide if releases or create PR
1818
runs-on: buildjet-4vcpu-ubuntu-2204
1919
permissions:
2020
contents: read
@@ -25,24 +25,24 @@ jobs:
2525
- uses: actions/checkout@v4
2626
with:
2727
fetch-depth: 0
28-
- name: Check if merge from changeset PR
29-
id: check-commit
28+
- id: check-commit
3029
env:
3130
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3231
run: |
3332
if [[ "${{ github.event.head_commit.message }}" == "Merge pull request"* ]]; then
3433
PR_NUMBER=$(echo "${{ github.event.head_commit.message }}" | grep -o '#[0-9]\+' | tr -d '#')
35-
if [ ! -z "$PR_NUMBER" ]; then
36-
PR_TITLE=$(gh pr view $PR_NUMBER --json title -q .title)
34+
if [ -n "$PR_NUMBER" ]; then
35+
PR_TITLE=$(gh pr view "$PR_NUMBER" --json title -q .title)
3736
if [[ "$PR_TITLE" == "ci(changesets): versioning packages" ]]; then
38-
echo "is_changeset_pr=true" >> $GITHUB_OUTPUT
37+
echo "is_changeset_pr=true" >> "$GITHUB_OUTPUT"
3938
exit 0
4039
fi
4140
fi
4241
fi
43-
echo "is_changeset_pr=false" >> $GITHUB_OUTPUT
42+
echo "is_changeset_pr=false" >> "$GITHUB_OUTPUT"
4443
4544
create-pr:
45+
name: Push changes to Changeset PR
4646
needs: check-commit
4747
if: needs.check-commit.outputs.is_changeset_pr == 'false'
4848
runs-on: buildjet-4vcpu-ubuntu-2204
@@ -79,6 +79,7 @@ jobs:
7979
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8080

8181
publish-npm:
82+
name: Release to NPM
8283
needs: check-commit
8384
if: needs.check-commit.outputs.is_changeset_pr == 'true'
8485
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)