-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: iOS crash when scenes are enabled #995
base: main
Are you sure you want to change the base?
fix: iOS crash when scenes are enabled #995
Conversation
🦋 Changeset detectedLatest commit: 773b378 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @kononenkoAnton thanks for the PR! This does seem like it works, but do you think you could provide us with a really stripped down minimal example repo of a RN app that supports I haven't used this before and have something clunky set up locally, but would love a reproducible app we could look at/test against in the future. Let me know, thanks! |
Hey @kononenkoAnton - just wanted to give you a friendly ping to see if you'd be up for providing a repro here! |
Hey @kononenkoAnton I've been running the https://github.com/microsoft/react-native-test-app without your fix, and it seems like it works correctly still. The RNTA (react-native-test-app) has multiple window support enabled by default and seemed like a good place to test this. I'm wondering if this might be an issue with your set up instead of an issue with the library. Let me know if you think you can provide a stripped down example of your implementation, thanks! |
Hi This PR really fix this issue. if (!presentingViewController) { Please consider merging this. |
Fixes #...
Description
iOS crashes when presenting a view controller while the application is using scenes: https://developer.apple.com/documentation/uikit/app_and_environment/scenes/
The issue occurs because each scene has its own window.
presentingViewController returns nil

Steps to verify