[IMP] Refactor and layout improvements

Author: Jacob Hicks

sale_pricelist_discount/README.rst

@@ -0,0 +1,58 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
+    :alt: License: AGPL-3
+
+Sale Pricelist Discount
+=======================
+
+This module allows specifying a default percentage discount to apply
+to sale order lines.  This ensures the pricelist discount is visible
+on quotations and sale orders.
+
+Installation
+============
+
+Nothing special is needed to install this module.
+
+Configuration
+=============
+
+Pricelist configuration:
+
+* Add discount percentage value to pricelist items for which the
+discount should be visible on sale order lines
+
+Usage
+=====
+
+* Select pricelist on sale order line
+
+* The discount defined on pricelist item will be populated as
+the sale order line discount percentage
+
+Known issues / Roadmap
+======================
+
+* Incompatible with product_visible_discount
+
+Credits
+=======
+
+Contributors
+------------
+
+* Jacob Hicks <jacob.hicks@credativ.co.uk>
+
+Maintainer
+----------
+
+.. image:: http://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: http://odoo-community.org
+
+This module is maintained by the OCA.
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+To contribute to this module, please visit http://odoo-community.org.

sale_pricelist_discount/__init__.py

@@ -2,7 +2,6 @@
 #
 #    OpenERP, Open Source Management Solution
 #    Copyright (C) 2015 credativ ltd (<http://www.credativ.co.uk>).
-#    All Rights Reserved
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU Affero General Public License as
@@ -20,5 +19,3 @@
 ##############################################################################
 
 from . import model
-
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

sale_pricelist_discount/__openerp__.py

@@ -2,7 +2,6 @@
 #
 #    OpenERP, Open Source Management Solution
 #    Copyright (C) 2015 credativ ltd (<http://www.credativ.co.uk>).
-#    All Rights Reserved
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU Affero General Public License as
@@ -28,17 +27,16 @@
 to sale order lines.  This ensures the pricelist discount is visible
 on quotations and sale orders.
     """,
-    'author': 'credativ',
+    'author': 'credativ, Odoo Community Association (OCA)',
     'website': 'http://www.credativ.co.uk',
     'depends': [
                 'base',
                 'sale',
                 'product',
     ],
-    'update_xml': [
+    'data': [
         'view/pricelist_view.xml'
     ],
     'auto_install': False,
     'installable': True,
 }
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

sale_pricelist_discount/model/__init__.py

@@ -2,7 +2,6 @@
 #
 #    OpenERP, Open Source Management Solution
 #    Copyright (C) 2015 credativ ltd (<http://www.credativ.co.uk>).
-#    All Rights Reserved
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU Affero General Public License as
@@ -21,5 +20,3 @@
 
 from . import pricelist
 from . import sale
-
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

sale_pricelist_discount/model/pricelist.py

@@ -3,7 +3,6 @@
 #
 #    OpenERP, Open Source Management Solution
 #    Copyright (C) 2015 credativ ltd (<http://www.credativ.co.uk>).
-#    All Rights Reserved
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU Affero General Public License as
@@ -20,23 +19,16 @@
 #
 ##############################################################################
 
-from openerp.osv import fields, osv
+from openerp import fields, models
 import openerp.addons.decimal_precision as dp
 
 
-class product_pricelist_item(osv.osv):
+class ProductPricelistItem(models.Model):
     _inherit = 'product.pricelist.item'
 
-    _columns = {
-        'discount': fields.float(
-            'Discount (%)',
-            digits_compute=dp.get_precision('Discount'),
-            help="Default discount applied on a sale order line.",
-        ),
-    }
-
-    _defaults = {
-        'discount': 0.0,
-    }
-
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+    discount = fields.Float(
+        'Discount (%)',
+        digits_compute=dp.get_precision('Discount'),
+        help="Default discount applied on a sale order line.",
+        default=0.0,
+    )

sale_pricelist_discount/model/sale.py

@@ -3,7 +3,6 @@
 #
 #    OpenERP, Open Source Management Solution
 #    Copyright (C) 2015 credativ ltd (<http://www.credativ.co.uk>).
-#    All Rights Reserved
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU Affero General Public License as
@@ -53,5 +52,3 @@ def product_id_change(
                 cr, uid, [rule_id], ['discount'])[0]['discount'] or 0.00
 
         return res
-
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: