Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close hanging forever #1

Open
pguillebert opened this issue Aug 25, 2015 · 2 comments
Open

close hanging forever #1

pguillebert opened this issue Aug 25, 2015 · 2 comments

Comments

@pguillebert
Copy link

I'm probably doing something wrong, I'm trying to test a simple use-case for s3-journal and everything works as intended, except close never finishes.

Here's my repro gist : https://gist.github.com/pguillebert/c2a0cea6b170d964ff32

The (.close) never finishes. I can see the file is uploaded successfully to S3 in the expected remote directory, but never get the "finished" message.

What am I doing wrong ?

Thanks.

@pguillebert
Copy link
Author

Setting max-batch-latency to 3 seconds was too short, when I set it to 30 seconds I can close the journal properly.

I guess setting this to a value under the value 5000 in s3_journal (line 347)

          (q/take! q :s3 5000 ::exhausted)

will trigger this behavior.

@ztellman
Copy link
Contributor

Hmm, we use a smaller latency than that in production, I'll take a look and see if I can figure out what's causing your failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants