-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Files Attachment Revisions #25
Comments
Of course, I’ll try to make SourCherry support it. I just can’t promise it will happen quickly, as I don’t have much free time these days. I still need to finish adding support for creating and editing lists. It’s almost finished, but I encountered an ugly bug that I have no idea how to solve at the moment. Those changes are in the master branch, and I don’t want to release a buggy app. I really should stop pushing changes to that branch until I’ve properly tested the new features. |
Personally I'd be perfectly happy with an apk build that just supports reading these databases, as I only use SourCherry as a viewer (read-only). So even if "editing" is still a work in progress until the next official release, it has no impact :) |
Alright he's got builds available now here: https://www.giuspen.net/cherrytree/#testing Is there by chance an easy way to make it just show the content of those nodes, even if it doesn't yet support launching the attachments? I tried to pull the code & global search for the string "hello" (just to see why it's showing that rather than the node content), but curiously, no hits at all 🤔 |
Because there isn't any
I downloaded appimage of the testing version and it still saves files with sha256sum as a filenames in the node dir. Am I missing something? Maybe there is a setting? |
Oh yeah sorry. Preferences -> Misc -> Multiple files storage, use embedded file name on disk
Strange. Here's what I see for any/every node with those attachments: The actual content of that node is file attachments: In CT itself: In any case, doesn't really matter if actual support for the attachments is being added :) Was just trying to bandaid it myself real quick so I wouldn't lose access to node content |
My guess would be that you have a node with I did a quick fix. It should load the content and I tried to fix opening of the file. Most likely saving the file to the device from the node will not work. I would not even consider this an alfa version. It most likely will have a lot of bugs (especially during editing). So You can download it from here. |
Checked that - I global searched for "hello" (with "override exclusions" enabled), and there were none with just that.
Confirmed - content is shown!
Unfortunately no go there - tapping the file shows a toast with "Failed to open the file"
No worries there - even just read-only is still super helpful. Thanks for looking into this so quick :) |
OK CT 1.3 is officially out now :) |
Hi,
Giuseppe has finally finished up the "multiple files in hierarchical storage" feature, including direct external editing of attachments. You can find builds here, he said the release will be published in a couple weeks.
Attachments look pretty much the same in the xml, the only change is that the attachment elements don't have a checksum & uses the filename directly, i.e. before:
...where the file on disk was like b10fb495652eddfd66cc7ab5755ced8ff633eb5af85a5e54e2e108a267f489b9.pdf. Now, if there's no checksum, it just uses the filename directly, like:
Currently SourCherry just displays "hello" in the content for any node with these types of attachments. Any chance of an easy fix? :)
The text was updated successfully, but these errors were encountered: