Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Builder class for Interface #338

Open
ddement opened this issue Jan 22, 2025 · 2 comments · May be fixed by #352
Open

Write Builder class for Interface #338

ddement opened this issue Jan 22, 2025 · 2 comments · May be fixed by #352
Assignees
@ddement @deslaughter @faisal-bhuiyan
Labels
code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc.

Comments

@ddement
Copy link
Collaborator

ddement commented Jan 22, 2025

Task: Write a Builder class to provide a more user friendly factory for the Interface class rather than using its constructor.

Why: A large monolithic constructor is not the best experience for our users - a factory class will make using our code much more ergonomic.

Done means: The new factory is written and all regression tests are updated to use it for Interface construction.
@ddement ddement added the code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc. label Jan 22, 2025
@ddement ddement self-assigned this Jan 22, 2025
@michaelasprague
Copy link
Contributor

This can move forward for the CFD interface. Made interface for building easier.

@faisal-bhuiyan faisal-bhuiyan linked a pull request Feb 17, 2025 that will close this issue
Added InterfaceBuilder to improve ergonomics of creating our CFD interface #352
Open
@michaelasprague
Copy link
Contributor

Incorporated feedback; in progress. Probably needs side discussion to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddement ddement

@deslaughter deslaughter

@faisal-bhuiyan faisal-bhuiyan

Labels
code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added InterfaceBuilder to improve ergonomics of creating our CFD interface Exawind/openturbine
4 participants
@michaelasprague @ddement @deslaughter @faisal-bhuiyan