Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for libocpp failed. #433

Closed
RichardWQJ opened this issue Feb 1, 2024 · 1 comment · Fixed by #435
Closed

Build for libocpp failed. #433

RichardWQJ opened this issue Feb 1, 2024 · 1 comment · Fixed by #435
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@RichardWQJ
Copy link

Hi professors,
I build for libocpp failed recently, due to error parameter of "on_session_started" in "src/charge_point.cpp" at line 280.
The parameter 2 should be a enum: ocpp::SessionStartedReason::EVConnected, not a string variable "EVConnected".

@Pietfried
Copy link
Contributor

Hi, thanks for pointing this out. The build examples are not yet included in the CI, so that slipped through. There might be some more issues with the build examples, because they haven't really been maintained in the past. Ill put the question about maintaining (or removing) on the agenda for the next working group meeting.

@Pietfried Pietfried added bug Something isn't working good first issue Good for newcomers labels Feb 1, 2024
@Pietfried Pietfried linked a pull request Feb 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants