Skip to content

Commit 7f41db7

Browse files
committed
Fix a bunch of style issues
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
1 parent f371c57 commit 7f41db7

File tree

5 files changed

+30
-35
lines changed

5 files changed

+30
-35
lines changed

include/ocpp/common/aligned_timer.hpp

+6-3
Original file line numberDiff line numberDiff line change
@@ -68,20 +68,23 @@ class ClockAlignedTimer : private Everest::Timer<std::chrono::system_clock> {
6868

6969
template <class Rep, class Period>
7070
system_time_point interval_starting_from(const std::function<void()>& callback,
71-
const std::chrono::duration<Rep, Period> interval, system_time_point start_point) {
71+
const std::chrono::duration<Rep, Period> interval,
72+
system_time_point start_point) {
7273
this->callback = callback;
7374
return this->interval_starting_from(interval, start_point);
7475
}
7576

7677
template <class Rep, class Period>
77-
system_time_point interval_starting_from(const std::chrono::duration<Rep, Period> interval, system_time_point start_point) {
78+
system_time_point interval_starting_from(const std::chrono::duration<Rep, Period> interval,
79+
system_time_point start_point) {
7880
this->start_point = start_point;
7981
this->call_interval = interval;
8082

8183
return this->call_next();
8284
}
8385

84-
template <class Rep, class Period> system_time_point set_interval(const std::chrono::duration<Rep, Period>& interval) {
86+
template <class Rep, class Period>
87+
system_time_point set_interval(const std::chrono::duration<Rep, Period>& interval) {
8588
this->call_interval = interval;
8689
return this->call_next();
8790
}

include/ocpp/v201/utils.hpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,9 @@ MeterValue get_meter_value_with_measurands_applied(const MeterValue& _meter_valu
3333
/// Sample_Clock will be filtered using \p aligned_tx_ended_measurands
3434
/// Any metervalue after \p max_timestamp will also be removed.
3535
///\retval filtered meter values
36-
std::vector<MeterValue>
37-
get_meter_values_with_measurands_applied(const std::vector<MeterValue>& meter_values,
38-
const std::vector<MeasurandEnum>& sampled_tx_ended_measurands,
39-
const std::vector<MeasurandEnum>& aligned_tx_ended_measurands,
40-
ocpp::DateTime max_timestamp);
36+
std::vector<MeterValue> get_meter_values_with_measurands_applied(
37+
const std::vector<MeterValue>& meter_values, const std::vector<MeasurandEnum>& sampled_tx_ended_measurands,
38+
const std::vector<MeasurandEnum>& aligned_tx_ended_measurands, ocpp::DateTime max_timestamp);
4139

4240
/// \brief Converts the given \p stop_reason to a TriggerReasonEnum
4341
/// \param stop_reason

lib/ocpp/v201/charge_point.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ void ChargePoint::on_transaction_finished(const int32_t evse_id, const DateTime&
352352
this->device_model->get_value<std::string>(ControllerComponentVariables::SampledDataTxEndedMeasurands)),
353353
utils::get_measurands_vec(
354354
this->device_model->get_value<std::string>(ControllerComponentVariables::AlignedDataTxEndedMeasurands)),
355-
timestamp));
355+
timestamp));
356356

357357
if (meter_values.value().empty()) {
358358
meter_values.reset();

lib/ocpp/v201/evse.cpp

+17-21
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ void Evse::open_transaction(const std::string& transaction_id, const int32_t con
9595
this->transaction_meter_value_req(this->get_meter_value(), this->transaction->get_transaction(),
9696
transaction->get_seq_no(), this->transaction->reservation_id);
9797
},
98-
sampled_data_tx_updated_interval,
99-
date::utc_clock::to_sys(timestamp.to_time_point()));
98+
sampled_data_tx_updated_interval, date::utc_clock::to_sys(timestamp.to_time_point()));
10099
}
101100

102101
if (sampled_data_tx_ended_interval > 0s) {
@@ -105,8 +104,7 @@ void Evse::open_transaction(const std::string& transaction_id, const int32_t con
105104
this->database_handler->transaction_metervalues_insert(this->transaction->transactionId.get(),
106105
this->get_meter_value());
107106
},
108-
sampled_data_tx_ended_interval,
109-
date::utc_clock::to_sys(timestamp.to_time_point()));
107+
sampled_data_tx_ended_interval, date::utc_clock::to_sys(timestamp.to_time_point()));
110108
}
111109

112110
if (aligned_data_tx_updated_interval > 0s) {
@@ -141,25 +139,23 @@ void Evse::open_transaction(const std::string& transaction_id, const int32_t con
141139

142140
if (aligned_data_tx_ended_interval > 0s) {
143141
auto store_aligned_metervalue = [this, aligned_data_tx_ended_interval] {
144-
auto meter_value = this->aligned_data_tx_end.retrieve_processed_values();
142+
auto meter_value = this->aligned_data_tx_end.retrieve_processed_values();
145143

146-
// If empty fallback on last updated metervalue
147-
if (meter_value.sampledValue.empty()) {
148-
meter_value = get_meter_value();
149-
}
144+
// If empty fallback on last updated metervalue
145+
if (meter_value.sampledValue.empty()) {
146+
meter_value = get_meter_value();
147+
}
150148

151-
for (auto& item : meter_value.sampledValue) {
152-
item.context = ReadingContextEnum::Sample_Clock;
153-
}
154-
if (this->device_model
155-
.get_optional_value<bool>(ControllerComponentVariables::RoundClockAlignedTimestamps)
156-
.value_or(false)) {
157-
meter_value.timestamp = utils::align_timestamp(DateTime{}, aligned_data_tx_ended_interval);
158-
}
159-
this->database_handler->transaction_metervalues_insert(this->transaction->transactionId.get(),
160-
meter_value);
161-
this->aligned_data_tx_end.clear_values();
162-
};
149+
for (auto& item : meter_value.sampledValue) {
150+
item.context = ReadingContextEnum::Sample_Clock;
151+
}
152+
if (this->device_model.get_optional_value<bool>(ControllerComponentVariables::RoundClockAlignedTimestamps)
153+
.value_or(false)) {
154+
meter_value.timestamp = utils::align_timestamp(DateTime{}, aligned_data_tx_ended_interval);
155+
}
156+
this->database_handler->transaction_metervalues_insert(this->transaction->transactionId.get(), meter_value);
157+
this->aligned_data_tx_end.clear_values();
158+
};
163159

164160
auto next_interval = transaction->aligned_tx_ended_meter_values_timer.interval_starting_from(
165161
store_aligned_metervalue, aligned_data_tx_ended_interval,

lib/ocpp/v201/utils.cpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,9 @@ MeterValue get_meter_value_with_measurands_applied(const MeterValue& _meter_valu
5151
return meter_value;
5252
}
5353

54-
std::vector<MeterValue>
55-
get_meter_values_with_measurands_applied(const std::vector<MeterValue>& meter_values,
56-
const std::vector<MeasurandEnum>& sampled_tx_ended_measurands,
57-
const std::vector<MeasurandEnum>& aligned_tx_ended_measurands,
58-
ocpp::DateTime max_timestamp) {
54+
std::vector<MeterValue> get_meter_values_with_measurands_applied(
55+
const std::vector<MeterValue>& meter_values, const std::vector<MeasurandEnum>& sampled_tx_ended_measurands,
56+
const std::vector<MeasurandEnum>& aligned_tx_ended_measurands, ocpp::DateTime max_timestamp) {
5957
std::vector<MeterValue> meter_values_result;
6058

6159
for (const auto& meter_value : meter_values) {

0 commit comments

Comments
 (0)