Skip to content

Commit f5095fa

Browse files
committed
Format
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
1 parent 1c60527 commit f5095fa

File tree

8 files changed

+20
-26
lines changed

8 files changed

+20
-26
lines changed

include/iso15118/d20/config.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ struct SessionConfig {
4242

4343
std::vector<message_20::datatypes::InternetParameterList> internet_parameter_list;
4444
std::vector<message_20::datatypes::ParkingParameterList> parking_parameter_list;
45-
45+
4646
// I have a deja vu with this DC limits, shouldn't they be called dc_evse_limits?
47-
DcTransferLimits dc_limits;
47+
DcTransferLimits dc_limits;
4848

4949
std::vector<ControlMobilityNeedsModes> supported_control_mobility_modes;
5050
};

include/iso15118/d20/context.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
#include "config.hpp"
1616
#include "control_event.hpp"
17-
#include "session.hpp"
1817
#include "ev_session_info.hpp"
18+
#include "session.hpp"
1919

2020
namespace iso15118::d20 {
2121

include/iso15118/d20/ev_session_info.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace iso15118::d20 {
88

99
// Holds information reported by the EV
10-
struct EVSessionInfo {
10+
struct EVSessionInfo {
1111
session::feedback::EV_TransferLimits ev_transfer_limits;
1212
session::feedback::EV_SEControlMode ev_control_mode;
1313
};

include/iso15118/detail/d20/state/dc_charge_parameter_discovery.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
#pragma once
44

55
#include <iso15118/d20/config.hpp>
6+
#include <iso15118/d20/ev_session_info.hpp>
67
#include <iso15118/d20/limits.hpp>
78
#include <iso15118/d20/session.hpp>
8-
#include <iso15118/d20/ev_session_info.hpp>
99
#include <iso15118/message/dc_charge_parameter_discovery.hpp>
1010

1111
namespace iso15118::d20::state {

include/iso15118/session/feedback.hpp

+8-13
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
#include <variant>
1010

1111
#include <iso15118/d20/limits.hpp>
12-
#include <iso15118/message/schedule_exchange.hpp>
1312
#include <iso15118/message/dc_charge_loop.hpp>
1413
#include <iso15118/message/dc_charge_parameter_discovery.hpp>
14+
#include <iso15118/message/schedule_exchange.hpp>
1515
#include <iso15118/message/type.hpp>
1616

1717
namespace iso15118::session {
@@ -40,21 +40,16 @@ struct DcMaximumLimits {
4040

4141
using PresentVoltage = dt::RationalNumber;
4242
using MeterInfoRequested = bool;
43-
using DcReqControlMode = std::variant<
44-
dt::Scheduled_DC_CLReqControlMode, dt::BPT_Scheduled_DC_CLReqControlMode,
45-
dt::Dynamic_DC_CLReqControlMode, dt::BPT_Dynamic_DC_CLReqControlMode>;
43+
using DcReqControlMode = std::variant<dt::Scheduled_DC_CLReqControlMode, dt::BPT_Scheduled_DC_CLReqControlMode,
44+
dt::Dynamic_DC_CLReqControlMode, dt::BPT_Dynamic_DC_CLReqControlMode>;
4645

47-
using DcChargeLoopReq =
48-
std::variant<DcReqControlMode, dt::DisplayParameters, PresentVoltage, MeterInfoRequested>;
46+
using DcChargeLoopReq = std::variant<DcReqControlMode, dt::DisplayParameters, PresentVoltage, MeterInfoRequested>;
4947

5048
// TODO(ioan): preparation for AC limits
51-
using EVSE_TransferLimits =
52-
std::variant<d20::DcTransferLimits>;
49+
using EVSE_TransferLimits = std::variant<d20::DcTransferLimits>;
5350

54-
using EV_TransferLimits =
55-
std::variant<dt::DC_CPDReqEnergyTransferMode, dt::BPT_DC_CPDReqEnergyTransferMode>;
56-
using EV_SEControlMode =
57-
std::variant<dt::Dynamic_SEReqControlMode, dt::Scheduled_SEReqControlMode>;
51+
using EV_TransferLimits = std::variant<dt::DC_CPDReqEnergyTransferMode, dt::BPT_DC_CPDReqEnergyTransferMode>;
52+
using EV_SEControlMode = std::variant<dt::Dynamic_SEReqControlMode, dt::Scheduled_SEReqControlMode>;
5853

5954
struct Callbacks {
6055
std::function<void(Signal)> signal;
@@ -85,7 +80,7 @@ class Feedback {
8580
void selected_protocol(const std::string&) const;
8681

8782
void notify_ev_charging_needs(const dt::ServiceCategory&, const dt::AcConnector&, const dt::ControlMode&,
88-
const dt::MobilityNeedsMode&, const feedback::EVSE_TransferLimits&,
83+
const dt::MobilityNeedsMode&, const feedback::EVSE_TransferLimits&,
8984
const feedback::EV_TransferLimits&) const;
9085

9186
private:

src/iso15118/d20/state/dc_charge_parameter_discovery.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ handle_request(const message_20::DC_ChargeParameterDiscoveryRequest& req, const
7676
}
7777

7878
// Extract info from the EV
79-
out_ev_session_info.ev_transfer_limits.emplace<BPT_DC_ModeReq>(std::get<BPT_DC_ModeReq>(req.transfer_mode));
79+
out_ev_session_info.ev_transfer_limits.emplace<BPT_DC_ModeReq>(std::get<BPT_DC_ModeReq>(req.transfer_mode));
8080

8181
auto& mode = res.transfer_mode.emplace<BPT_DC_ModeRes>();
8282
convert(mode, dc_limits);
@@ -119,7 +119,7 @@ Result DC_ChargeParameterDiscovery::feed(Event ev) {
119119
logf_info("Max charge current %fA", dt::from_RationalNumber(mode->max_charge_current));
120120
logf_info("Max discharge current %fA", dt::from_RationalNumber(mode->max_discharge_current));
121121
}
122-
122+
123123
const auto res = handle_request(*req, m_ctx.session, m_ctx.session_config.dc_limits, m_ctx.session_ev_info);
124124

125125
m_ctx.respond(res);

src/iso15118/d20/state/schedule_exchange.cpp

+4-5
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,13 @@ Result ScheduleExchange::feed(Event ev) {
147147
const session::feedback::EVSE_TransferLimits& evse_limits = m_ctx.session_config.dc_limits;
148148
const session::feedback::EV_TransferLimits& ev_limits = m_ctx.session_ev_info.ev_transfer_limits;
149149

150-
// TODO: send and transform
150+
// TODO: send and transform
151151
const session::feedback::EV_SEControlMode control_mode = req->control_mode;
152152

153153
// Send the charging feedback
154-
this->m_ctx.feedback.notify_ev_charging_needs(selected_energy_service, ac_connector,
155-
selected_services.selected_control_mode,
156-
selected_services.selected_mobility_needs_mode,
157-
evse_limits, ev_limits);
154+
this->m_ctx.feedback.notify_ev_charging_needs(
155+
selected_energy_service, ac_connector, selected_services.selected_control_mode,
156+
selected_services.selected_mobility_needs_mode, evse_limits, ev_limits);
158157

159158
const auto res = handle_request(*req, m_ctx.session, max_charge_power, dynamic_parameters);
160159

test/iso15118/states/dc_charge_parameter_discovery.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// Copyright 2023 Pionix GmbH and Contributors to EVerest
33
#include <catch2/catch_test_macros.hpp>
44

5-
#include <iso15118/detail/d20/state/dc_charge_parameter_discovery.hpp>
65
#include <iso15118/d20/ev_session_info.hpp>
6+
#include <iso15118/detail/d20/state/dc_charge_parameter_discovery.hpp>
77

88
using namespace iso15118;
99

0 commit comments

Comments
 (0)