Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msal-react-lite/example/package.json doesn't work for me #2

Open
metrozwale opened this issue Nov 24, 2020 · 2 comments
Open

msal-react-lite/example/package.json doesn't work for me #2

metrozwale opened this issue Nov 24, 2020 · 2 comments
Assignees

Comments

@metrozwale
Copy link

This is the very first thing I've ever entered into github so there is a huge risk I am committing [no pun] an error in protocol so for that let me apologize first. If I have done, just let me know.
The package.json for the example (msal-react-lite/example/package.json) has relative paths (../) that seem to confuse npm start.
For example, I see: "start": "node ../node_modules/react-scripts/bin/react-scripts.js start",
instead of the more typical: "start": "react-scripts start",
I've had a hack but I can't get the scripting and dependency detection working properly.
There is every chance it is my ignorance responsible but I don't know where to start looking since the npm stuff has always just "worked"; I use it without really understanding the subtleties.
I am clearly missing something fundamental. Any hints?
BTW, I think this component is exactly what we need at the moment for some work we are doing which is why I'm risking annoying you with this.
Thanks for the effort in the build!

@gidich
Copy link
Member

gidich commented Nov 30, 2020

Are you looking to run the project from GitHub or incorporate msal-react-lite into an existing project?

Running it from the source in GitHub is only required if you're looking to make modifications to the project and submit a pull request.

@gidich gidich self-assigned this Nov 30, 2020
@metrozwale
Copy link
Author

metrozwale commented Nov 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants