Skip to content

Commit cd98475

Browse files
committed
Merge branch '2.1' into 3.1
2 parents d739ab6 + 530beae commit cd98475

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

core/src/main/java/org/apache/accumulo/core/util/compaction/RunningCompactionInfo.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public RunningCompactionInfo(TExternalCompaction ec) {
7575
if (lastEntry != null) {
7676
last = lastEntry.getValue();
7777
updateMillis = lastEntry.getKey();
78-
duration = last.getCompactionAgeNanos();
78+
duration = NANOSECONDS.toMillis(last.getCompactionAgeNanos());
7979
} else {
8080
log.debug("No updates found for {}", ecid);
8181
lastUpdate = 1;
@@ -84,7 +84,7 @@ public RunningCompactionInfo(TExternalCompaction ec) {
8484
duration = 0;
8585
return;
8686
}
87-
long durationMinutes = NANOSECONDS.toMinutes(duration);
87+
long durationMinutes = MILLISECONDS.toMinutes(duration);
8888
if (durationMinutes > 15) {
8989
log.warn("Compaction {} has been running for {} minutes", ecid, durationMinutes);
9090
}

server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/ec.js

-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ $(function () {
8080
"columnDefs": [{
8181
"targets": "duration",
8282
"render": function (data, type, row) {
83-
data = data / 1_000_000; // convert from nanos to millis
8483
if (type === 'display') data = timeDuration(data);
8584
return data;
8685
}

test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionProgressIT.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package org.apache.accumulo.test.compaction;
2020

2121
import static com.google.common.util.concurrent.Uninterruptibles.sleepUninterruptibly;
22-
import static java.util.concurrent.TimeUnit.NANOSECONDS;
22+
import static java.util.concurrent.TimeUnit.MILLISECONDS;
2323
import static org.apache.accumulo.core.metrics.Metric.COMPACTOR_ENTRIES_READ;
2424
import static org.apache.accumulo.core.metrics.Metric.COMPACTOR_ENTRIES_WRITTEN;
2525
import static org.apache.accumulo.test.compaction.ExternalCompactionTestUtils.QUEUE1;
@@ -184,7 +184,7 @@ public void testCompactionDurationContinuesAfterCoordinatorStop() throws Excepti
184184
.getCompactions().values().iterator().next();
185185
RunningCompactionInfo updatedCompactionInfo = new RunningCompactionInfo(updatedCompaction);
186186

187-
final Duration reportedCompactionDuration = Duration.ofNanos(updatedCompactionInfo.duration);
187+
final Duration reportedCompactionDuration = Duration.ofMillis(updatedCompactionInfo.duration);
188188
final Duration measuredCompactionDuration =
189189
Duration.ofNanos(System.nanoTime() - compactionStartTime);
190190
final Duration coordinatorAge = Duration.ofNanos(System.nanoTime() - coordinatorRestartTime);
@@ -431,7 +431,7 @@ private void checkRunning() throws TException {
431431
RunningCompactionInfo rci = new RunningCompactionInfo(ec);
432432
RunningCompactionInfo previousRci = runningMap.put(ecid, rci);
433433
log.debug("ECID {} has been running for {} seconds", ecid,
434-
NANOSECONDS.toSeconds(rci.duration));
434+
MILLISECONDS.toSeconds(rci.duration));
435435
if (previousRci == null) {
436436
log.debug("New ECID {} with inputFiles: {}", ecid, rci.numFiles);
437437
} else {

0 commit comments

Comments
 (0)