Move set creation outside of method to avoid recreation

Author: DomGarguilo

core/src/main/java/org/apache/accumulo/core/metrics/MetricsInfo.java

@@ -23,6 +23,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
+import java.util.Set;
 
 import com.google.common.net.HostAndPort;
 
@@ -36,6 +37,9 @@ public interface MetricsInfo {
   String HOST_TAG_KEY = "host";
   String PORT_TAG_KEY = "port";
 
+  Set<String> allTags = Set.of(INSTANCE_NAME_TAG_KEY, PROCESS_NAME_TAG_KEY, RESOURCE_GROUP_TAG_KEY,
+      HOST_TAG_KEY, PORT_TAG_KEY);
+
   /**
    * Convenience method to create tag name / value pair for the instance name
    *

server/base/src/main/java/org/apache/accumulo/server/metrics/MetricResponseWrapper.java

@@ -18,20 +18,14 @@
  */
 package org.apache.accumulo.server.metrics;
 
-import static org.apache.accumulo.core.metrics.MetricsInfo.HOST_TAG_KEY;
-import static org.apache.accumulo.core.metrics.MetricsInfo.INSTANCE_NAME_TAG_KEY;
-import static org.apache.accumulo.core.metrics.MetricsInfo.PORT_TAG_KEY;
-import static org.apache.accumulo.core.metrics.MetricsInfo.PROCESS_NAME_TAG_KEY;
-import static org.apache.accumulo.core.metrics.MetricsInfo.RESOURCE_GROUP_TAG_KEY;
-
 import java.nio.ByteBuffer;
 import java.util.List;
-import java.util.Set;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Consumer;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import org.apache.accumulo.core.metrics.MetricsInfo;
 import org.apache.accumulo.core.metrics.flatbuffers.FMetric;
 import org.apache.accumulo.core.metrics.flatbuffers.FTag;
 import org.apache.accumulo.core.metrics.thrift.MetricResponse;
@@ -54,7 +48,7 @@
  */
 public class MetricResponseWrapper extends MetricResponse {
 
-  private class CommonRefs {
+  private static class CommonRefs {
     int nameRef;
     int typeRef;
     int tagsRef;
@@ -82,11 +76,8 @@ public MetricResponseWrapper(FlatBufferBuilder builder) {
    * Remove tags from the Metric that duplicate other information found in the MetricResponse
    */
   private List<Tag> reduceTags(List<Tag> tags, List<Tag> extraTags) {
-    final Set<String> existingTags = Set.of(INSTANCE_NAME_TAG_KEY, PROCESS_NAME_TAG_KEY,
-        RESOURCE_GROUP_TAG_KEY, HOST_TAG_KEY, PORT_TAG_KEY);
-
     return Stream.concat(tags.stream(), extraTags.stream())
-        .filter(t -> !existingTags.contains(t.getKey())).collect(Collectors.toList());
+        .filter(t -> !MetricsInfo.allTags.contains(t.getKey())).collect(Collectors.toList());
   }
 
   private void parseAndCreateCommonInfo(Meter.Id id, List<Tag> extraTags) {