Add time based retry upper bound to calculation loop

Author: DomGarguilo

core/src/main/java/org/apache/accumulo/core/util/Retry.java

@@ -404,9 +404,13 @@ private void calculateRetriesWithinDuration() {
       long numberOfRetries = 0;
       long cumulativeWaitTimeMillis = 0;
       long currentWaitTimeMillis = initialWait.toMillis();
-      long retriesForDurationMillis = retriesForDuration.toMillis();
+      final long retriesForDurationMillis = retriesForDuration.toMillis();
 
-      while (cumulativeWaitTimeMillis + currentWaitTimeMillis <= retriesForDurationMillis) {
+      // set an upper bound for the number of retries
+      final long maxRetries = Duration.ofHours(1).toMillis();
+
+      while (cumulativeWaitTimeMillis + currentWaitTimeMillis <= retriesForDurationMillis
+          && numberOfRetries < maxRetries) {
 
         cumulativeWaitTimeMillis += currentWaitTimeMillis;
         numberOfRetries++;
@@ -421,10 +425,6 @@ private void calculateRetriesWithinDuration() {
           currentWaitTimeMillis = maxWait.toMillis(); // Ensure wait time does not exceed maxWait
         }
 
-        // prevent an infinite loop
-        if (numberOfRetries >= Integer.MAX_VALUE) {
-          break;
-        }
       }
 
       this.maxRetries = numberOfRetries;