Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LB stat files should not be written out every phase and should be marked with a trace event #2388

Closed
lifflander opened this issue Jan 9, 2025 · 0 comments · Fixed by #2393
Closed

LB stat files should not be written out every phase and should be marked with a trace event #2388

lifflander opened this issue Jan 9, 2025 · 0 comments · Fixed by #2393
Assignees
@cwschilly
Labels
type: bug

Comments

@lifflander
Copy link
Collaborator

Describe the bug
I think we should output them every 100 or so phases, maybe with a user-settable flag? We should mark these with a bracketed trace user event so we know how much it costs.
cwschilly added a commit that referenced this issue Jan 10, 2025
@cwschilly
#2388: add lb_stats_freq flag and mark output with a trace event
74af511
@cwschilly cwschilly mentioned this issue Jan 10, 2025
Merged
@cwschilly cwschilly linked a pull request Jan 10, 2025 that will close this issue
#2388: LB stat files should not be written out every phase and should be marked with a trace event #2393
Merged
cwschilly added a commit that referenced this issue Jan 10, 2025
@cwschilly
#2388: fix spacing
72a07e9
cwschilly added a commit that referenced this issue Jan 30, 2025
@cwschilly
#2388: lb_stats: register event for writing lb stats
966c8df
cwschilly added a commit that referenced this issue Jan 30, 2025
@cwschilly
#2388: add lb_stats_freq flag and mark output with a trace event
1133d2d
cwschilly added a commit that referenced this issue Jan 30, 2025
@cwschilly
#2388: fix spacing
3ef3e3b
cwschilly added a commit that referenced this issue Jan 30, 2025
@cwschilly
#2388: lb_stats: register event for writing lb stats
968c2b9
cwschilly added a commit that referenced this issue Feb 3, 2025
@cwschilly
#2388: check if lb stats event has already been created
2f1d718
cwschilly added a commit that referenced this issue Feb 7, 2025
@cwschilly
#2388: set lb stats write event on startup
5ba7405
cwschilly added a commit that referenced this issue Feb 7, 2025
@cwschilly
#2388: add lb_stats_freq flag and mark output with a trace event
bfb1989
cwschilly added a commit that referenced this issue Feb 7, 2025
@cwschilly
#2388: fix spacing
d6f4d94
cwschilly added a commit that referenced this issue Feb 7, 2025
@cwschilly
#2388: lb_stats: register event for writing lb stats
edf929e
cwschilly added a commit that referenced this issue Feb 7, 2025
@cwschilly
#2388: check if lb stats event has already been created
26b626a
cwschilly added a commit that referenced this issue Feb 7, 2025
@cwschilly
#2388: set lb stats write event on startup
5744127
cwschilly added a commit that referenced this issue Feb 10, 2025
@cwschilly
#2388: move write_stats_event to lb manager
1771158
lifflander added a commit that referenced this issue Feb 13, 2025
@lifflander
Merge pull request #2393 from DARMA-tasking/2388-lb-stat-files-should…
fcc894c 
…-not-be-written-out-every-phase-and-should-be-marked-with-a-trace-event

#2388: LB stat files should not be written out every phase and should be marked with a trace event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwschilly cwschilly

Labels
type: bug
Projects
None yet
Milestone
No milestone
2 participants
@lifflander @cwschilly