Skip to content

Commit a9c5ac3

Browse files
cwschillycz4rs
authored andcommitted
#2201: pass memory_threshold to config generator
1 parent fe8a977 commit a9c5ac3

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

tests/unit/lb/test_temperedlb.cc

+10-14
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace vt { namespace tests { namespace unit { namespace lb {
1212
using TestTemperedLB = TestParallelHarness;
1313

1414
std::string writeTemperedLBConfig(
15-
std::string transfer_strategy, bool mem_constraints, double alpha = 1.0,
15+
std::string transfer_strategy, double memory_threshold, double alpha = 1.0,
1616
double beta = 0.0, double gamma = 0.0, double delta = 0.0
1717
) {
1818
auto const this_node = theContext()->getNode();
@@ -25,11 +25,7 @@ std::string writeTemperedLBConfig(
2525
" gamma=" << gamma <<
2626
" delta=" << delta;
2727
if (transfer_strategy == "SwapClusters") {
28-
if (mem_constraints) {
29-
cfg_file_ << " memory_threshold=20.0";
30-
} else {
31-
cfg_file_ << " memory_threshold=1e8";
32-
}
28+
cfg_file_ << " memory_threshold=" << memory_threshold;
3329
}
3430
cfg_file_.close();
3531
}
@@ -66,49 +62,49 @@ void runTemperedLBTest(std::string config_file, double expected_imb = 0.0) {
6662

6763
TEST_F(TestTemperedLB, test_load_only_original) {
6864
SET_NUM_NODES_CONSTRAINT(4);
69-
auto cfg = writeTemperedLBConfig("Original", false);
65+
auto cfg = writeTemperedLBConfig("Original", 1e8);
7066
runTemperedLBTest(cfg);
7167
}
7268

7369
TEST_F(TestTemperedLB, test_load_only_swapclusters) {
7470
SET_NUM_NODES_CONSTRAINT(4);
75-
auto cfg = writeTemperedLBConfig("SwapClusters", false);
71+
auto cfg = writeTemperedLBConfig("SwapClusters", 1e8);
7672
runTemperedLBTest(cfg, 0.25);
7773
}
7874

7975
TEST_F(TestTemperedLB, test_load_and_memory_swapclusters) {
8076
SET_NUM_NODES_CONSTRAINT(4);
81-
auto cfg = writeTemperedLBConfig("SwapClusters", true);
77+
auto cfg = writeTemperedLBConfig("SwapClusters", 20);
8278
runTemperedLBTest(cfg, 0.25);
8379
}
8480

8581
TEST_F(TestTemperedLB, test_load_no_memory_delta_10) {
8682
SET_NUM_NODES_CONSTRAINT(4);
87-
auto cfg = writeTemperedLBConfig("SwapClusters", false, 1, 0, 0, 1);
83+
auto cfg = writeTemperedLBConfig("SwapClusters", 1e8, 1, 0, 0, 1);
8884
runTemperedLBTest(cfg, 1.0);
8985
}
9086

9187
TEST_F(TestTemperedLB, test_load_no_memory_delta_01) {
9288
SET_NUM_NODES_CONSTRAINT(4);
93-
auto cfg = writeTemperedLBConfig("SwapClusters", false, 1, 0, 0, 0.1);
89+
auto cfg = writeTemperedLBConfig("SwapClusters", 1e8, 1, 0, 0, 0.1);
9490
runTemperedLBTest(cfg, 0.25);
9591
}
9692

9793
TEST_F(TestTemperedLB, test_load_memory_delta_01) {
9894
SET_NUM_NODES_CONSTRAINT(4);
99-
auto cfg = writeTemperedLBConfig("SwapClusters", true, 1, 0, 0, 0.1);
95+
auto cfg = writeTemperedLBConfig("SwapClusters", 20, 1, 0, 0, 0.1);
10096
runTemperedLBTest(cfg, 0.25);
10197
}
10298

10399
TEST_F(TestTemperedLB, test_load_no_memory_delta_03) {
104100
SET_NUM_NODES_CONSTRAINT(4);
105-
auto cfg = writeTemperedLBConfig("SwapClusters", false, 1, 0, 0, 0.3);
101+
auto cfg = writeTemperedLBConfig("SwapClusters", 1e8, 1, 0, 0, 0.3);
106102
runTemperedLBTest(cfg, 1.0);
107103
}
108104

109105
TEST_F(TestTemperedLB, test_load_memory_delta_03) {
110106
SET_NUM_NODES_CONSTRAINT(4);
111-
auto cfg = writeTemperedLBConfig("SwapClusters", true, 1, 0, 0, 0.3);
107+
auto cfg = writeTemperedLBConfig("SwapClusters", 20, 1, 0, 0, 0.3);
112108
runTemperedLBTest(cfg, 1.0);
113109
}
114110

0 commit comments

Comments
 (0)