Skip to content

Commit 2fd8152

Browse files
lifflanderlifflander
authored
Merge pull request #2360 from DARMA-tasking/2286-remove-gcc-8-support
#2286: Remove `gcc-8` support
2 parents 66786a6 + b492585 commit 2fd8152

27 files changed

+96
-503
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ If applicable, add screenshots to help explain your problem.
2525

2626
**Platform (please complete the following information):**
2727
- Supercomputer or desktop [e.g., Trinity, Sierra)
28-
- Compiler environment [e.g., clang-4.0, gcc8]
28+
- Compiler environment [e.g., clang-4.0, gcc9]
2929
- Libraries [e.g., mpich-2, openmpi)
3030
- Commit ID or release of VT [e.g., vt-1.0.0]
3131

‎README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
[![codecov](https://codecov.io/gh/DARMA-tasking/vt/branch/develop/graph/badge.svg)](https://codecov.io/gh/DARMA-tasking/vt)
55
[![License](https://img.shields.io/badge/License-BSD%203--Clause-orange.svg)](https://opensource.org/licenses/BSD-3-Clause)
66
![](https://github.com/DARMA-tasking/vt/workflows/Docker%20Image%20CI/badge.svg)
7-
[![gcc-8, ubuntu, mpich, address sanitizer](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-8%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer)?branchName=develop&Label=(gcc-8%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=9&branchName=develop)
87
[![gcc-9, ubuntu, mpich, zoltan](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-9%2C%20ubuntu%2C%20mpich%2C%20zoltan)?branchName=develop&Label=(gcc-9%2C%20ubuntu%2C%20mpich%2C%20zoltan))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=10&branchName=develop)
98
[![gcc-10, ubuntu, openmpi, no LB](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB)?branchName=develop&Label=(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=4&branchName=develop)
109
[![gcc-11, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-11%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-11%2C%20ubuntu%2C%20mpich%2C%20trace%20runtime%2C%20coverage))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=29&branchName=develop)
1110
[![gcc-12, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-12%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-12%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=30&branchName=develop)
11+
[![gcc-13, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-13%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer)?branchName=develop&Label=(gcc-13%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=36&branchName=develop)
1212
[![clang-9, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-9%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-9.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=22&branchName=develop)
1313
[![clang-10, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-10%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-10.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=21&branchName=develop)
1414
[![clang-11, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-11%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-11.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=25&branchName=develop)

‎ci/azure/azure-clang-16-ubuntu-mpich.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
############## Warning this is a generated file---do not modify ###############
33
###############################################################################
44

5-
name: PR tests (clang-16, ubuntu, mpich)
5+
name: PR tests (clang-16, ubuntu, mpich, json schema test)
66

77
trigger:
88
branches:
@@ -58,7 +58,7 @@ variables:
5858
VT_KOKKOS_ENABLED: 0
5959
VT_TV_ENABLED: 0
6060
CMAKE_CXX_STANDARD: 17
61-
VT_CI_TEST_LB_SCHEMA: 0
61+
VT_CI_TEST_LB_SCHEMA: 1
6262
RUN_FULL_CI: true
6363
CACHE: "$(Agent.TempDirectory)/cache/"
6464
cache_name: ubuntu-clang-16-cache

‎ci/azure/azure-gcc-8-ubuntu-mpich.yml ‎ci/azure/azure-gcc-13-ubuntu-mpich.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
############## Warning this is a generated file---do not modify ###############
33
###############################################################################
44

5-
name: PR tests (gcc-8, ubuntu, mpich, address sanitizer)
5+
name: PR tests (gcc-13, ubuntu, mpich, address sanitizer)
66

77
trigger:
88
branches:
@@ -25,10 +25,10 @@ variables:
2525
tag: '$(Build.BuildId)'
2626
REPO: lifflander1/vt
2727
ARCH: amd64
28-
UBUNTU: 18.04
28+
UBUNTU: 24.04
2929
COMPILER_TYPE: gnu
30-
COMPILER: gcc-8
31-
HOST_COMPILER: gcc-8
30+
COMPILER: gcc-13
31+
HOST_COMPILER: gcc-13
3232
BUILD_TYPE: release
3333
ULIMIT_CORE: 0
3434
VT_CODE_COVERAGE: 0
@@ -61,7 +61,7 @@ variables:
6161
VT_CI_TEST_LB_SCHEMA: 0
6262
RUN_FULL_CI: true
6363
CACHE: "$(Agent.TempDirectory)/cache/"
64-
cache_name: ubuntu-gcc-8-cache
64+
cache_name: ubuntu-gcc-13-cache
6565
volume_name: ubuntu-cpp
6666
build_root: "$(CACHE)$(ARCH)-ubuntu-$(UBUNTU)-$(HOST_COMPILER)-$(COMPILER)-cache/"
6767
TS: 0

‎ci/azure/azure-gcc-9-ubuntu-mpich.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
############## Warning this is a generated file---do not modify ###############
33
###############################################################################
44

5-
name: PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)
5+
name: PR tests (gcc-9, ubuntu, mpich, zoltan)
66

77
trigger:
88
branches:
@@ -58,7 +58,7 @@ variables:
5858
VT_KOKKOS_ENABLED: 0
5959
VT_TV_ENABLED: 0
6060
CMAKE_CXX_STANDARD: 17
61-
VT_CI_TEST_LB_SCHEMA: 1
61+
VT_CI_TEST_LB_SCHEMA: 0
6262
RUN_FULL_CI: true
6363
CACHE: "$(Agent.TempDirectory)/cache/"
6464
cache_name: ubuntu-gcc-9-cache

‎ci/docker/alpine-cpp.dockerfile

-37
Original file line numberDiff line numberDiff line change
@@ -52,43 +52,6 @@ ENV CC=mpicc \
5252

5353
FROM base as build
5454
COPY . /vt
55-
56-
ARG VT_LB_ENABLED
57-
ARG VT_TRACE_ENABLED
58-
ARG VT_TRACE_RUNTIME_ENABLED
59-
ARG VT_MIMALLOC_ENABLED
60-
ARG VT_DOXYGEN_ENABLED
61-
ARG VT_ASAN_ENABLED
62-
ARG VT_UBSAN_ENABLED
63-
ARG VT_WERROR_ENABLED
64-
ARG VT_POOL_ENABLED
65-
ARG VT_PRODUCTION_BUILD_ENABLED
66-
ARG VT_FCONTEXT_ENABLED
67-
ARG CMAKE_BUILD_TYPE
68-
ARG VT_NO_COLOR_ENABLED
69-
ARG BUILD_SHARED_LIBS
70-
ARG CMAKE_CXX_STANDARD
71-
ARG VT_DEBUG_VERBOSE
72-
ARG VT_CI_BUILD
73-
74-
ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
75-
VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
76-
VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
77-
VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
78-
VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
79-
VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
80-
VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
81-
VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
82-
VT_POOL_ENABLED=${VT_POOL_ENABLED} \
83-
VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
84-
VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
85-
VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
86-
CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
87-
BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
88-
CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
89-
VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
90-
VT_CI_BUILD=${VT_CI_BUILD}
91-
9255
RUN /vt/ci/build_cpp.sh /vt /build
9356

9457
FROM build as test

‎ci/docker/develop.dockerfile

-44
Original file line numberDiff line numberDiff line change
@@ -31,50 +31,6 @@ RUN if test ${zoltan_enabled} -eq 1; then \
3131

3232
COPY . /vt
3333

34-
ARG VT_LB_ENABLED
35-
ARG VT_TRACE_ENABLED
36-
ARG VT_TRACE_RUNTIME_ENABLED
37-
ARG VT_MIMALLOC_ENABLED
38-
ARG VT_DOXYGEN_ENABLED
39-
ARG VT_ASAN_ENABLED
40-
ARG VT_UBSAN_ENABLED
41-
ARG VT_WERROR_ENABLED
42-
ARG VT_POOL_ENABLED
43-
ARG VT_PRODUCTION_BUILD_ENABLED
44-
ARG VT_ZOLTAN_ENABLED
45-
ARG CMAKE_BUILD_TYPE
46-
ARG VT_EXTENDED_TESTS_ENABLED
47-
ARG VT_FCONTEXT_ENABLED
48-
ARG VT_NO_COLOR_ENABLED
49-
ARG BUILD_SHARED_LIBS
50-
ARG CMAKE_CXX_STANDARD
51-
ARG VT_DEBUG_VERBOSE
52-
ARG VT_CI_BUILD
53-
54-
ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
55-
VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
56-
VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
57-
VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
58-
VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
59-
VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
60-
VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
61-
VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
62-
VT_POOL_ENABLED=${VT_POOL_ENABLED} \
63-
VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
64-
VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
65-
VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \
66-
VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
67-
VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
68-
VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
69-
VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
70-
VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
71-
VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
72-
CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
73-
BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
74-
CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
75-
VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
76-
VT_CI_BUILD=${VT_CI_BUILD}
77-
7834
RUN /vt/ci/build_cpp.sh /vt /build
7935
RUN /vt/ci/test_cpp.sh /vt /build
8036
RUN /vt/ci/build_vt_sample.sh /vt /build

‎ci/docker/ubuntu-20.04-gnu-openmpi-cpp.dockerfile

-45
Original file line numberDiff line numberDiff line change
@@ -78,51 +78,6 @@ ENV OMPI_ALLOW_RUN_AS_ROOT=1 \
7878

7979
FROM base as build
8080
COPY . /vt
81-
82-
ARG VT_LB_ENABLED
83-
ARG VT_TRACE_ENABLED
84-
ARG VT_TRACE_RUNTIME_ENABLED
85-
ARG VT_MIMALLOC_ENABLED
86-
ARG VT_DOXYGEN_ENABLED
87-
ARG VT_ASAN_ENABLED
88-
ARG VT_UBSAN_ENABLED
89-
ARG VT_WERROR_ENABLED
90-
ARG VT_POOL_ENABLED
91-
ARG VT_PRODUCTION_BUILD_ENABLED
92-
ARG VT_ZOLTAN_ENABLED
93-
ARG VT_FCONTEXT_ENABLED
94-
ARG CMAKE_BUILD_TYPE
95-
ARG VT_EXTENDED_TESTS_ENABLED
96-
ARG VT_NO_COLOR_ENABLED
97-
ARG BUILD_SHARED_LIBS
98-
ARG CMAKE_CXX_STANDARD
99-
ARG VT_DEBUG_VERBOSE
100-
ARG VT_CI_BUILD
101-
102-
ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
103-
VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
104-
VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
105-
VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
106-
VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
107-
VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
108-
VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
109-
VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
110-
VT_POOL_ENABLED=${VT_POOL_ENABLED} \
111-
VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
112-
VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \
113-
VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
114-
VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
115-
VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
116-
VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
117-
VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
118-
VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
119-
VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
120-
CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
121-
BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
122-
CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
123-
VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
124-
VT_CI_BUILD=${VT_CI_BUILD}
125-
12681
RUN /vt/ci/build_cpp.sh /vt /build
12782

12883
FROM build as test

‎ci/docker/ubuntu-clang-cpp.dockerfile

+24-65
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ARG arch=amd64
22
ARG ubuntu=20.04
3-
FROM ${arch}/ubuntu:${ubuntu} as base
3+
FROM ${arch}/ubuntu:${ubuntu} AS base
44

55
ARG proxy=""
66
ARG compiler=clang-11
@@ -14,22 +14,27 @@ ENV DEBIAN_FRONTEND=noninteractive
1414

1515
RUN apt-get update -y -q && \
1616
apt-get install -y -q --no-install-recommends \
17-
${compiler} \
18-
${ubsan_enabled:+llvm-$(echo ${compiler} | cut -d- -f2)} \
19-
ca-certificates \
20-
ccache \
21-
curl \
22-
git \
23-
less \
24-
libomp-dev \
25-
libomp5 \
26-
make-guile \
27-
ninja-build \
28-
python3 \
29-
valgrind \
30-
wget \
31-
zlib1g \
32-
zlib1g-dev && \
17+
${compiler} \
18+
${ubsan_enabled:+llvm-$(echo ${compiler} | cut -d- -f2)} \
19+
brotli \
20+
ca-certificates \
21+
ccache \
22+
curl \
23+
git \
24+
less \
25+
libomp-dev \
26+
libomp5 \
27+
make-guile \
28+
ninja-build \
29+
python3 \
30+
python3-brotli \
31+
python3-deepdiff \
32+
python3-pip \
33+
python3-schema \
34+
valgrind \
35+
wget \
36+
zlib1g \
37+
zlib1g-dev && \
3338
apt-get clean && \
3439
rm -rf /var/lib/apt/lists/*
3540

@@ -52,10 +57,7 @@ ENV PATH=/cmake/bin/:$PATH
5257
ENV LESSCHARSET=utf-8
5358

5459
COPY ./ci/deps/mpich.sh mpich.sh
55-
RUN if [ "$ubuntu" = "18.04" ]; then \
56-
./mpich.sh 3.3.2 -j4; else \
57-
./mpich.sh 4.0.2 -j4; \
58-
fi
60+
RUN ./mpich.sh 4.0.2 -j4
5961

6062
ENV MPI_EXTRA_FLAGS="" \
6163
CMAKE_PREFIX_PATH="/lib/x86_64-linux-gnu/" \
@@ -64,52 +66,9 @@ ENV MPI_EXTRA_FLAGS="" \
6466

6567
FROM base as build
6668
COPY . /vt
67-
68-
ARG BUILD_SHARED_LIBS
69-
ARG CMAKE_BUILD_TYPE
70-
ARG VT_ASAN_ENABLED
71-
ARG VT_DOXYGEN_ENABLED
72-
ARG VT_EXTENDED_TESTS_ENABLED
73-
ARG VT_FCONTEXT_ENABLED
74-
ARG VT_LB_ENABLED
75-
ARG VT_MIMALLOC_ENABLED
76-
ARG VT_NO_COLOR_ENABLED
77-
ARG VT_POOL_ENABLED
78-
ARG VT_PRODUCTION_BUILD_ENABLED
79-
ARG VT_TRACE_ENABLED
80-
ARG VT_TRACE_RUNTIME_ENABLED
81-
ARG VT_UBSAN_ENABLED
82-
ARG VT_WERROR_ENABLED
83-
ARG CMAKE_CXX_STANDARD
84-
ARG VT_DEBUG_VERBOSE
85-
ARG VT_CI_BUILD
86-
87-
ENV BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
88-
CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
89-
VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
90-
VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
91-
VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
92-
VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
93-
VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
94-
VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
95-
VT_LB_ENABLED=${VT_LB_ENABLED} \
96-
VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
97-
VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
98-
VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
99-
VT_POOL_ENABLED=${VT_POOL_ENABLED} \
100-
VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
101-
VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
102-
VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
103-
VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
104-
VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
105-
VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
106-
CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
107-
VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
108-
VT_CI_BUILD=${VT_CI_BUILD}
109-
11069
RUN /vt/ci/build_cpp.sh /vt /build
11170

112-
FROM build as test
71+
FROM build AS test
11372
RUN /vt/ci/test_cpp.sh /vt /build
11473

11574
RUN /vt/ci/build_vt_sample.sh /vt /build

0 commit comments

Comments
 (0)