#1934: Remove unnecessary resizes

Author: thearusable

src/vt/elm/elm_lb_data.h

@@ -131,12 +131,12 @@ struct ElementLBData {
   bool cur_time_started_ = false;
   TimeType cur_time_ = TimeType{0.0};
   PhaseType cur_phase_ = fst_lb_phase;
-  util::container::CircularPhasesBuffer<LoadType> phase_timings_ = {1};
-  util::container::CircularPhasesBuffer<CommMapType> phase_comm_ = {1};
+  util::container::CircularPhasesBuffer<LoadType> phase_timings_;
+  util::container::CircularPhasesBuffer<CommMapType> phase_comm_;
 
   SubphaseType cur_subphase_ = 0;
-  util::container::CircularPhasesBuffer<std::vector<LoadType>> subphase_timings_ = {1};
-  util::container::CircularPhasesBuffer<std::vector<CommMapType>> subphase_comm_ = {1};
+  util::container::CircularPhasesBuffer<std::vector<LoadType>> subphase_timings_;
+  util::container::CircularPhasesBuffer<std::vector<CommMapType>> subphase_comm_;
 };
 
 }} /* end namespace vt::elm */

src/vt/vrt/collection/balance/lb_data_holder.cc

@@ -169,7 +169,7 @@ std::unique_ptr<nlohmann::json> LBDataHolder::toJson(PhaseType phase) const {
       }
       outputEntity(j["tasks"][i]["entity"], id);
 
-      if (node_user_attributes_.find(phase) != node_user_attributes_.end()) {
+      if (node_user_attributes_.contains(phase)) {
         if (node_user_attributes_.at(phase).find(id) != node_user_attributes_.at(phase).end()) {
           for (auto const& [key, value] : node_user_attributes_.at(phase).at(id)) {
             if (std::holds_alternative<int>(value)) {
@@ -262,14 +262,6 @@ std::unique_ptr<nlohmann::json> LBDataHolder::toJson(PhaseType phase) const {
   return std::make_unique<json>(std::move(j));
 }
 
-LBDataHolder::LBDataHolder(std::size_t initial_buffers_size)
-  : node_data_(initial_buffers_size),
-    node_comm_(initial_buffers_size),
-    node_subphase_comm_(initial_buffers_size),
-    user_defined_json_(initial_buffers_size),
-    user_defined_lb_info_(initial_buffers_size)
-    { }
-
 LBDataHolder::LBDataHolder(nlohmann::json const& j)
 {
   auto this_node = theContext()->getNode();

src/vt/vrt/collection/balance/lb_data_holder.h

@@ -67,13 +67,6 @@ namespace vt { namespace vrt { namespace collection { namespace balance {
 struct LBDataHolder {
   LBDataHolder() = default;
 
-  /**
-   * \brief Create \c LBDataHolder with specified buffers capacity
-   *
-   * \param[in] initial_buffers_size the initial size of the buffers
-   */
-  LBDataHolder(std::size_t initial_buffers_size);
-
   /**
    * \brief Create \c LBDataHolder from input JSON
    *
@@ -158,7 +151,7 @@ struct LBDataHolder {
   /// User-defined data from each phase for LB
   DataMapBufferType user_defined_lb_info_;
   /// User-defined attributes from each phase
-  std::unordered_map<PhaseType, DataMapType> node_user_attributes_;
+  DataMapBufferType node_user_attributes_;
   /// Node indices for each ID along with the proxy ID
   std::unordered_map<ElementIDStruct, std::tuple<VirtualProxyType, std::vector<uint64_t>>> node_idx_;
   /// Map from id to objgroup proxy

tests/unit/collection/test_workload_data_migrator.cc

@@ -93,7 +93,7 @@ setupWorkloads(PhaseType phase, size_t numElements) {
     );
   }
 
-  auto lbdh = std::make_shared<LBDataHolder>(numElements);
+  auto lbdh = std::make_shared<LBDataHolder>();
 
   for (auto&& elmID : myElemList) {
     double tval = elmID.id * 2;
@@ -790,7 +790,7 @@ setupManyWorkloads(
     );
   }
 
-  auto lbdh = std::make_shared<LBDataHolder>(num_phases);
+  auto lbdh = std::make_shared<LBDataHolder>();
 
   PhaseType stop_phase = initial_phase + num_phases;
   for (PhaseType phase = initial_phase; phase < stop_phase; ++phase) {
@@ -804,7 +804,7 @@ setupManyWorkloads(
     }
   }
 
-  auto scrambled_lbdh = std::make_shared<LBDataHolder>(num_phases);
+  auto scrambled_lbdh = std::make_shared<LBDataHolder>();
 
   for (PhaseType phase = initial_phase; phase < stop_phase; ++phase) {
     auto base_load_model = setupBaseModel(phase, lbdh);