Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LB iterations #566

Closed
ppebay opened this issue Dec 10, 2024 · 1 comment · Fixed by #570
Closed

Support LB iterations #566

ppebay opened this issue Dec 10, 2024 · 1 comment · Fixed by #570
Assignees
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Dec 10, 2024

This is related to vt#2375

@lifflander if you want to add something

In the JSON for a phase:

"phases":
  [
     {
       "id": ...,
       "tasks": ...,
       "communications": ...,
       "lb_iterations": [
         {
           "id": ...,
           "tasks": ...,
           "communications": ...
         }
       ]
     }
  ]
@ppebay ppebay added the enhancement New feature or request label Dec 10, 2024
@ppebay ppebay self-assigned this Dec 10, 2024
@ppebay
Copy link
Contributor Author

ppebay commented Dec 12, 2024

@lifflander should the writing of intermediate load-balancing iterations occur in offline_LB_compatible mode only, or in all cases? If I am not mistaken, the former is what is typically used when LBAF processes pure vt outputs.

ppebay added a commit that referenced this issue Dec 12, 2024
ppebay added a commit that referenced this issue Dec 13, 2024
ppebay added a commit that referenced this issue Dec 13, 2024
ppebay added a commit that referenced this issue Dec 13, 2024
ppebay added a commit that referenced this issue Dec 13, 2024
* #566: added infrastructure for parameters for lb iterations

* #566: corrected incorrect handling of Bool/int

* #566: eliminated "distributions" that are no longer needed

* #566: no notion of QOI needed here any longer

* #566: removed distributions

* #566: fix test to reflect removal of stats/distr

* #566: fixed failure of centralized test

* #566: fixed bug in computation of Hamming distance to optimum

* #566: clarified doc

* #566: eliminated now unused notion of QOIs

* #566: reduced computation of stats to what is needed: max load and total work

* #566: make stat update message debug only

* #566: removed QOIs from test harness

* #566: removed forgotten QOIs
github-actions bot pushed a commit that referenced this issue Dec 13, 2024
* #566: added infrastructure for parameters for lb iterations

* #566: corrected incorrect handling of Bool/int

* #566: eliminated distributions that are no longer needed

* #566: no notion of QOI needed here any longer

* #566: removed distributions

* #566: fix test to reflect removal of stats/distr

* #566: fixed failure of centralized test

* #566: fixed bug in computation of Hamming distance to optimum

* #566: clarified doc

* #566: eliminated now unused notion of QOIs

* #566: reduced computation of stats to what is needed: max load and total work

* #566: make stat update message debug only

* #566: removed QOIs from test harness

* #566: removed forgotten QOIs
ppebay added a commit that referenced this issue Dec 14, 2024
ppebay added a commit that referenced this issue Dec 14, 2024
ppebay added a commit that referenced this issue Dec 14, 2024
ppebay added a commit that referenced this issue Dec 14, 2024
ppebay added a commit that referenced this issue Dec 14, 2024
ppebay added a commit that referenced this issue Dec 15, 2024
ppebay added a commit that referenced this issue Dec 15, 2024
ppebay added a commit that referenced this issue Dec 15, 2024
ppebay added a commit that referenced this issue Dec 16, 2024
cwschilly added a commit that referenced this issue Dec 16, 2024
ppebay added a commit that referenced this issue Dec 16, 2024
ppebay added a commit that referenced this issue Dec 16, 2024
ppebay added a commit that referenced this issue Dec 17, 2024
ppebay added a commit that referenced this issue Dec 18, 2024
ppebay added a commit that referenced this issue Dec 18, 2024
ppebay added a commit that referenced this issue Dec 18, 2024
ppebay added a commit that referenced this issue Dec 18, 2024
ppebay added a commit that referenced this issue Dec 18, 2024
* #566: use lower case in function makes as per PEP

* #566: fixed imports from PR569 in cases when lbaf package not installed

* #566: fixed incorrect comment

* #566: Python style: do not use LB but lb

* #566: fixed instances of LB in files

* #566: LB iterations persist as sub-indexed phases

* #566: old style typing needed for 3.8 to pass

* #566: fixed tests for new syntax

* #566: fixed more test errors

* #566: restored defaut conf.yaml

* #566: progress checkpoint to exercise CI -- iterations passed to writer

* #566: whitespace cleanup

* #566: fixed typo

* #566: completed implementation

* #566: fixed bug that prevented supporting online compatibility

* #566: fixed whitespace cleanup

* #566: Ensure proper retention in correct phase of lb iterations in offline mode

* #566: resolve pylint errors

* #566: proper initialization

* #566: factor out identical rank copying and fixed duplicate code

* #566: no typing inside implementations

* #566: reorganized code and fixed lb iterations comm

* #566: whitespace cleanup

* #566: fix communications variable name

* #566: fixed missing communications

* #566: removed debug statements

* #566: style

* #566: removed forgotten test routine bypass

* #566: fixed bug

* #566: whitespace cleanup and other improvements

---------

Co-authored-by: Caleb Schilly <cwschilly@gmail.com>
Co-authored-by: Pierre Pebay <pebay.pierre@gmail.com>
github-actions bot pushed a commit that referenced this issue Dec 18, 2024
* #566: use lower case in function makes as per PEP

* #566: fixed imports from PR569 in cases when lbaf package not installed

* #566: fixed incorrect comment

* #566: Python style: do not use LB but lb

* #566: fixed instances of LB in files

* #566: LB iterations persist as sub-indexed phases

* #566: old style typing needed for 3.8 to pass

* #566: fixed tests for new syntax

* #566: fixed more test errors

* #566: restored defaut conf.yaml

* #566: progress checkpoint to exercise CI -- iterations passed to writer

* #566: whitespace cleanup

* #566: fixed typo

* #566: completed implementation

* #566: fixed bug that prevented supporting online compatibility

* #566: fixed whitespace cleanup

* #566: Ensure proper retention in correct phase of lb iterations in offline mode

* #566: resolve pylint errors

* #566: proper initialization

* #566: factor out identical rank copying and fixed duplicate code

* #566: no typing inside implementations

* #566: reorganized code and fixed lb iterations comm

* #566: whitespace cleanup

* #566: fix communications variable name

* #566: fixed missing communications

* #566: removed debug statements

* #566: style

* #566: removed forgotten test routine bypass

* #566: fixed bug

* #566: whitespace cleanup and other improvements

---------

Co-authored-by: Caleb Schilly <cwschilly@gmail.com>
Co-authored-by: Pierre Pebay <pebay.pierre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant