Skip to content

Commit 9884cb1

Browse files
committed
#507: remove config file test; clean up viz deprecation
1 parent 4238367 commit 9884cb1

File tree

3 files changed

+0
-56
lines changed

3 files changed

+0
-56
lines changed

src/lbaf/Applications/LBAF_app.py

-7
Original file line numberDiff line numberDiff line change
@@ -573,13 +573,6 @@ def run(self):
573573
"Grid size: {self.__parameters.grid_size} < {n_ranks}")
574574
raise SystemExit(1)
575575

576-
# Look for prescribed QOI bounds
577-
qoi_request = [
578-
self.__parameters.rank_qoi,
579-
self.__parameters.work_model.get("parameters", {}).get("upper_bounds", {}).get(self.__parameters.rank_qoi),
580-
self.__parameters.object_qoi
581-
]
582-
583576
# Call vttv visualization
584577
if using_vttv:
585578
self.__logger.info("Calling vt-tv")

tests/unit/IO/test_lbs_visualizer_deprecation.py

-8
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,5 @@ def test_lbs_visualizer_deprecation(self):
1818
except DeprecationWarning as e:
1919
assert str(e) == "LBAF's Visualizer has been deprecated and will be removed in a future release. Visualizations should be generated with DARMA/vt-tv."
2020

21-
def test_lbs_visualizer_config(self):
22-
config_file = os.path.join(os.path.dirname(os.path.dirname(__file__)), "config", "conf_wrong_visualization.yml")
23-
pipes = subprocess.Popen(["python", "src/lbaf", "-c", config_file], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
24-
std_err = pipes.communicate()[1].decode("utf-8")
25-
26-
assert pipes.returncode != 0
27-
assert "DeprecationWarning: LBAF\'s Visualizer has been deprecated and will be removed in a future release. Visualizations should be generated with DARMA/vt-tv." in std_err
28-
2921
if __name__ == "__main__":
3022
unittest.main()

tests/unit/config/conf_wrong_visualization.yml

-41
This file was deleted.

0 commit comments

Comments
 (0)