Disk ID

[oneingan]

Hi, I have an use case where hardware provisioner gives me SCSI controller number and disk port to initialize and format disk.

I make a custom fact to retrieve this info but maybe you are interested in support this feature also:

Facter.value(:disks).each do |disk, values|
      disks[disk] = {
        'scsiport' => Facter::Core::Execution.exec("find -L /dev/disk/by-path/ -samefile /dev/#{disk} | awk -F'[:.]' '{print $6}'"),
      }
    end

In future I'll use your implementation because your high quality code and standard de facto.
Thanks in advance and apologize my english.

[cygnusb]

We can use this, but you should implement this more proper. Please do not use a exec call, since this can be done by pure ruby code only. In addition the name of scsiport is a bit too generic. Please consider naming it a bit more reasonable. You might implement this and create a pull request.