Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formalize attributes config name and line-endings issue + setup github workflow #1

Merged
merged 20 commits into from
Mar 1, 2024
Merged

Fix formalize attributes config name and line-endings issue + setup github workflow #1

merged 20 commits into from
Mar 1, 2024

Conversation

harmen-xb
Copy link
Contributor

  • Fix formalize attribute attribute name in config.
  • Moved test files into PowerDeComposer maven project.
  • Setup github workflow for build, test and package to jar activities.
  • Updated logging setup so it works more convenient.
  • Added test scenarios (and needed steps) for line-end handling (CR vs CRLF).
  • Fixed issue with line endings while writing include files during decompose.

@harmen-xb
Fixed naming error from formalizeExtendedAtrributes to formalizeExten…
7ba5ae2 
…dedAttributes.
@harmen-xb
Refactored PowerDeComposerTest into PowerDeComposer maven project.
f70e1f7 
Updated pom to include needed dependencies, updated scm paths, updated executable jar creation to be in line with XG.
@harmen-xb
Added github workflows.
92d233a
@harmen-xb
Updated pom schemagen settings.
db188a1 
Updated xsd using schemagen.
Updated gitignore.
Removed azure pipeline and generate jar scripts.
@harmen-xb
Removed episode file.
148f55b
@harmen-xb
Updated logging properties so everything is not logged twice.
f736538
@harmen-xb
Added unit tests for new line handing in compose phase.
74dbcd4 
Refactired Steps a bit to support prepared test files (separate from runtime).
@harmen-xb
Created gitattributes file for test files (to make sure CR and CRLF a…
6d53342 
…re captured in Git as created).
@harmen-xb
Updated line enddings in Git after gitattributes setting.
dd17c48
@harmen-xb
Added matrix in job to run on windows and linux.
ee26abc
@harmen-xb
Removed vscode settings.
82c4a30
@harmen-xb
Disabled fail-fast in workflow job.
8b2fe37
@harmen-xb
Added os and java version to test result name.
7e3276b 
Add condition for publishing jar only in linux run.
@harmen-xb
Refactored logging to use global logger and setup INFO for normal use…
f043129 
… and FINE for testing.
@harmen-xb
Updated spaces/tabs in feature file.
4c57bc6 
Removed unneeded semi-colon.
@harmen-xb
Changed all feature files from LF to CRLF.
86c5f61 
Added closing streams when writing file.
@harmen-xb
Updated Steps to always have CRLF for inline Cucumber content (and no…
c134710 
…t otherwise).
@harmen-xb
Added java version to jar artifact.
34d3fc2 
Added jdk 17 to matrix.
@harmen-xb
Added tests (with steps) to verify new-line handling on Decompose pro…
4ca167f 
…cess.
@harmen-xb
Refactored getVTDNav function in XmlUtils to work in byte[] so we can…
f2bc109 
… pass the byte[] of an XML fargment, i.s.o. the string.

Changed decomposer to get the byte[] of the decompose file parts to solve the line-ending issue.
@harmen-xb harmen-xb self-assigned this Feb 28, 2024
@willem-xbreeze willem-xbreeze merged commit de88a7e into main Mar 1, 2024
8 checks passed
@willem-xbreeze willem-xbreeze deleted the feature/fix-formalize-attributes branch March 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willem-xbreeze willem-xbreeze willem-xbreeze approved these changes

Assignees

@harmen-xb harmen-xb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harmen-xb @willem-xbreeze