Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch5-video no longer tells all ch5-background to let video through #273

Open
jadeva opened this issue Feb 28, 2024 · 1 comment
Open

ch5-video no longer tells all ch5-background to let video through #273

jadeva opened this issue Feb 28, 2024 · 1 comment

Comments

@jadeva
Copy link

jadeva commented Feb 28, 2024

TB Case#: 00198843

Since commit 95a46ec video does not show through multiple ch5-backgrounds.

Previously you fetches all ch5-background elements to tell them to let the video though.
In the mentioned commit you changed this to only let video through on a hardcoded element id (used by the shell template) and a parent ch5-background.

The issue can easily be seen on line 460 in ch5-video.ts in the new commit.

From:

private ch5BackgroundElements: HTMLCollectionOf<Ch5Background> = document.getElementsByTagName('ch5-background') as HTMLCollectionOf<Ch5Background>;

To:

private shellCh5Background: Ch5Background | null = document.getElementById('template-content-background') as Ch5Background;
private parentCh5Background: Ch5Background | null = null;

We really need the video to be able to go through multiple ch5-backgrounds.

@rdabbir-crestron
Copy link
Contributor

rdabbir-crestron commented Apr 10, 2024

Please check the 2.9.0 release of Ch5. This is fixed in the release. Please close the ticket once validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants