Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tried adding option to insert arbitrary model #38

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

Takatho
Copy link
Contributor

@Takatho Takatho commented Sep 27, 2024

Adressing issue #37

@MetinSa MetinSa self-requested a review September 27, 2024 13:11
@MetinSa
Copy link
Collaborator

MetinSa commented Sep 27, 2024

Looks nice, good job! I will make some slight edits and add some units tests and then we are ready for a merge :)

@MetinSa
Copy link
Collaborator

MetinSa commented Sep 27, 2024

To test that the code works remember to follow the instruction in the README, specifically by running pytest, ruff and mypy as instructed. I will modify the code to make sure the tests and linting is happy:)

…date validation of the argument. Write unit tests for the change and update the example in `docs/` to reflect the changes
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (38a3e8a) to head (f8e6bad).
Report is 68 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #38      +/-   ##
===========================================
+ Coverage   98.76%   100.00%   +1.23%     
===========================================
  Files          19        14       -5     
  Lines         807       708      -99     
===========================================
- Hits          797       708      -89     
+ Misses         10         0      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MetinSa MetinSa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition to ZodiPy as it allows for visualization and gridding of custom non-registered models. Initial state did not pass tests and were not formatted. This is now fixed and the PR is ready to be merged.

@MetinSa MetinSa added the enhancement New feature or request label Sep 27, 2024
@MetinSa MetinSa linked an issue Sep 27, 2024 that may be closed by this pull request
@MetinSa
Copy link
Collaborator

MetinSa commented Sep 27, 2024

@Takatho if you take a look at the changes ive made, the argument name is now replaced with model to better reflect the two new possible types. Make sure to change this in your code!

@MetinSa MetinSa merged commit 952c4b1 into Cosmoglobe:main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid_number_density should accept custom models
2 participants