-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signatures, as these really only make sense in that context (I think). Also, start the migration from healpy to astropy-healpix
… search is much slower than to just compute the angular separation between the pointing
Replace healpy with astropy-healpi. Add new API to directly support SkyCoord objects. Move freq and weights arguments to Zodipy object initialization and away from methods
This was
linked to
issues
Apr 29, 2024
…integration of near observer dust where its brightest
Add support for specifying an `obstime` and `obspos` per coordinate.
… to the model initialization. Refactor variable and function names.
…nate. Split the main body of the `evaluate` method into its separate function for easier multiprocessing. Modify error messages for invalid input arguments.
…resulted in parallel evaluation being computed in sequence.
nostutzer
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will include all changes in the first new major ZodiPy release (v1.0.0) 🎉
Changes
obstime
andobspos
per coordinate to make ZodiPy better fit for time-ordered analysis.The new public interface will look something like:
The idea is that at the end of this, ZodiPy should be used maybe as:
This will require major changes to the public API.
TODO:
freq
andweights
to the ZodiPy initializer. This only needs to happen once when the model is initialized, and not every time the methods are run.SkyCoord
objects to unifytheta
,phi
,lonlat
, andobstime
into onecoord
argument.evaluate
method with a signature on the form ofevaluate(coords, obspos)
. The previousget_emission_ang
, ``get_binned_emission_ang,
get_emission_pix`, and `get_binned_emission_pix` are all deleted. Rather than internally converting from healpix and `theta` `phi` to `SkyCoord` this now has to happen on the user end, but this is trivial with Astropy-healpix.scipy.interp1d
is depcrated Replace SciPy'sinterp1d
with new intended interpolation API #27 Attempts to fix #27, currently fails due to keyword arguments in interp_kind #28astropy.models.physical_models.BlackBody
instead of custom Plancks law implementationSee if we can integrate synphot to do bandpass evaluationsThis was decided to be a bit overkill for the simple trapezoidal integration required by ZodiPy (see Usesynphot
package to perform bandpass integration #21 )astropy.modeling.physical_models.BlackBody
tabluate_number_density
function.multiprocessing.Pool
object be injected instead of created if desired. ~~This does currently not work as intended. Move to another release or drop feature until requested.