Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_number_density should accept custom models #37

Closed
dncnwtts opened this issue Sep 23, 2024 · 1 comment · Fixed by #38
Closed

grid_number_density should accept custom models #37

dncnwtts opened this issue Sep 23, 2024 · 1 comment · Fixed by #38
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dncnwtts
Copy link
Contributor

I would like to make small changes to the sky model and output 3D grids as a function of these parameters. Unfortunately, the call for grid_number_density requires the name of a built-in model.

I would like it to be possible for a custom ipd_model to be an argument, in case the user has this. So basically, either name or ipd_model could be an argument.

One idea we have had is adding new models to the registry, but that would be cumbersome in the case of trying to make a list of ~1000 different parameters.

@dncnwtts dncnwtts self-assigned this Sep 23, 2024
@dncnwtts dncnwtts added enhancement New feature or request good first issue Good for newcomers labels Sep 23, 2024
@MetinSa
Copy link
Collaborator

MetinSa commented Sep 23, 2024

Good suggestion! I suggesting it accepting either a str, and if so it is a built-in model, or a custom model object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants