Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bandpass evaluation and construction #26

Closed
MetinSa opened this issue Apr 27, 2024 · 1 comment · Fixed by #29
Closed

Move bandpass evaluation and construction #26

MetinSa opened this issue Apr 27, 2024 · 1 comment · Fixed by #29
Assignees
@MetinSa
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@MetinSa
Copy link
Collaborator

MetinSa commented Apr 27, 2024

This will does not need to be recomputed every time the model is evaluated. This would make it necessary initialize several models if one wishes to evaluate over several bandpasses. Perhaps it could be cached instead?
@MetinSa MetinSa added the enhancement New feature or request label Apr 27, 2024
@MetinSa MetinSa self-assigned this Apr 27, 2024
@MetinSa MetinSa changed the title Move bandpass evaluation and construction of density partials to model initialiation Move bandpass evaluation and construction Apr 29, 2024
MetinSa added a commit that referenced this issue Apr 29, 2024
@MetinSa
Move bandpass calculations to Zodipy init fixing #26 and fix bug with…
d053282 
… ephem
@MetinSa MetinSa linked a pull request Apr 29, 2024 that will close this issue
v1.0.0 #29
Merged
16 tasks
@MetinSa MetinSa added this to the v1.0.0 milestone May 1, 2024
@MetinSa
Copy link
Collaborator Author

MetinSa commented May 1, 2024

This is now done for v1.0.0.

@MetinSa MetinSa closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MetinSa MetinSa

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

v1.0.0 Cosmoglobe/zodipy
1 participant
@MetinSa