Exploring error in custom gate

Author: hJaffaliColibritd

mpqp/core/circuit.py

@@ -650,7 +650,8 @@ def to_other_language(
 
                 if isinstance(instruction, CustomGate):
                     new_circ.unitary(instruction.to_other_language(), instruction.targets, instruction.label)
-                    #TODO hamza: to test, maybe need to reverse the order of elements in the matrix
+                    # FIXME: minus sign appearing when it should not, seems there a phase added somewhere, check u gate
+                    #  in OpenQASM translation.
                     continue
                 elif isinstance(instruction, ControlledGate):
                     qargs = instruction.controls + instruction.targets

mpqp/core/instruction/gates/native_gates.py

@@ -45,7 +45,6 @@
 from mpqp.tools.generics import Matrix
 from mpqp.tools.maths import cos, sin, exp
 
-
 @typechecked
 def _qiskit_parameter_adder(param: Expr | float, qiskit_parameters: set[Parameter]):
     """To avoid having several parameters in qiskit for the same value we keep
@@ -194,6 +193,14 @@ def __init__(self, target: int):
         SingleQubitGate.__init__(self, target, type(self).__name__)
 
 
+class Id(OneQubitNoParamGate, InvolutionGate):
+    """TODO hamza/muhammad
+    """
+
+    qiskit_gate = ...
+    matrix = ...
+
+
 class X(OneQubitNoParamGate, InvolutionGate):
     """One qubit X (NOT) Pauli gate.
 
@@ -625,3 +632,8 @@ def to_matrix(self) -> Matrix:
         m = np.identity(8, dtype=complex)
         m[-2:, -2:] = np.ones(2) - np.identity(2)
         return m
+
+
+NATIVE_GATES = [CNOT, CRk, CZ, H, Id, P, Rk, Rx, Ry, Rz, S, SWAP, T, TOF, U, X, Y, Z]
+# TODO : check the possibility to detect when a custom gate can be defined as a native gate, problem with
+#  parametrized gates maybe