Merge pull request #97 from ColibrITD-SAS/feat-qiskit-device-noisemodel

IBM Simulated device + Shots/Precision fix + IBM Noisy Expectation Value + Upgrade packages

Author: hJaffaliColibritd

docs/execution.rst

@@ -23,6 +23,13 @@ Devices
 
 .. automodule:: mpqp.execution.devices
 
+.. _SimulatedDevices:
+
+Simulated Devices
+-----------------
+
+.. automodule:: mpqp.execution.simulated_devices
+
 Running a circuit
 -----------------
 

docs/noise.rst

@@ -13,6 +13,9 @@ We strongly encourage the user to have a look at the
 details about the manipulation, usage, and simulation of noise models are 
 presented.
 
+For more details on how to use noise models taken from real hardware, you can
+look at :ref:`SimulatedDevices`.
+
 .. code-block:: python
     :class: import
 

docs/resources/job-device_compat.csv

@@ -3,28 +3,22 @@ IBM      ,AER_SIMULATOR                     ,✓      ,✓            ,✓
 IBM      ,AER_SIMULATOR_STATEVECTOR         ,✓      ,✓            ,✓          ,✓
 IBM      ,AER_SIMULATOR_DENSITY_MATRIX      ,✓      ,             ,✓          ,✓
 IBM      ,AER_SIMULATOR_STABILIZER          ,✓      ,             ,✓          ,✓
-IBM      ,AER_SIMULATOR_EXTENDED_STABILIZER ,✓      ,✓            ,✓          ,✓
+IBM      ,AER_SIMULATOR_EXTENDED_STABILIZER ,✓      ,✓            ,           ,
 IBM      ,AER_SIMULATOR_MATRIX_PRODUCT_STATE,✓      ,✓            ,✓          ,✓
 IBM      ,IBM_BRISBANE                      ,✓      ,             ,✓          ,
-IBM      ,IBM_OSAKA                         ,✓      ,             ,✓          ,
-IBM      ,IBM_KYOTO                         ,✓      ,             ,✓          ,
 IBM      ,IBM_SHERBROOKE                    ,✓      ,             ,✓          ,
 IBM      ,IBM_KYIV                          ,✓      ,             ,✓          ,
 IBM      ,IBM_NAZCA                         ,✓      ,             ,✓          ,
-IBM      ,IBM_CUSCO                         ,✓      ,             ,✓          ,
-IBM      ,IBM_ITHACA                        ,✓      ,             ,✓          ,
 IBM      ,IBM_TORINO                        ,✓      ,             ,✓          ,
 IBM      ,IBM_QUEBEC                        ,✓      ,             ,✓          ,
 IBM      ,IBM_KAWASAKI                      ,✓      ,             ,✓          ,
 IBM      ,IBM_CLEVELAND                     ,✓      ,             ,✓          ,
-IBM      ,IBM_CAIRO                         ,✓      ,             ,✓          ,
-IBM      ,IBM_HANOI                         ,✓      ,             ,✓          ,
-IBM      ,IBM_ALGIERS                       ,✓      ,             ,✓          ,
-IBM      ,IBM_KOLKATA                       ,✓      ,             ,✓          ,
-IBM      ,IBM_MUMBAI                        ,✓      ,             ,✓          ,
 IBM      ,IBM_PEEKSKILL                     ,✓      ,             ,✓          ,
-IBM      ,IBM_RANDOM_SMALL_DEVICE           ,✓      ,             ,✓          ,
-IBM      ,IBM_SMALL_DEVICES_LEAST_BUSY      ,✓      ,             ,✓          ,
+IBM      ,IBM_RENSSELAER                    ,✓      ,             ,✓          ,
+IBM      ,IBM_BRUSSELS                      ,✓      ,             ,✓          ,
+IBM      ,IBM_STRASBOURG                    ,✓      ,             ,✓          ,
+IBM      ,IBM_FEZ                           ,✓      ,             ,✓          ,
+IBM      ,IBM_LEAST_BUSY                    ,✓      ,             ,✓          ,
 Atos     ,MYQLM_PYLINALG                    ,✓      ,✓            ,✓          ,✓
 Atos     ,MYQLM_CLINALG                     ,✓      ,✓            ,✓          ,✓
 Atos     ,QLM_LINALG                        ,✓      ,✓            ,✓          ,✓

mpqp/all.py

@@ -24,6 +24,7 @@
     IBMDevice,
     AZUREDevice,
 )
+from .execution.simulated_devices import IBMSimulatedDevice
 from .execution.remote_handler import get_all_job_ids
 from .execution.vqa import Optimizer, minimize
 from .gates import (
@@ -69,6 +70,8 @@
 from .measures import Z as Zop
 from .noise import AmplitudeDamping, BitFlip, Depolarizing, PhaseDamping
 from .qasm import open_qasm_file_conversion_2_to_3, open_qasm_hard_includes
+from .tools.circuit import random_circuit
+from .tools.display import pprint
 
 theta, k = symbols("θ k")
 obs = Observable(np.array([[0, 1], [1, 0]]))

mpqp/execution/connection/ibm_connection.py

@@ -1,16 +1,16 @@
 from getpass import getpass
 from typing import TYPE_CHECKING
 
+from mpqp.execution.connection.env_manager import get_env_variable, save_env_variable
+from mpqp.execution.devices import IBMDevice
+from mpqp.tools.errors import IBMRemoteExecutionError
 from termcolor import colored
 from typeguard import typechecked
 
 if TYPE_CHECKING:
     from qiskit.providers.backend import BackendV2
     from qiskit_ibm_runtime import QiskitRuntimeService
 
-from mpqp.execution.connection.env_manager import get_env_variable, save_env_variable
-from mpqp.execution.devices import IBMDevice
-from mpqp.tools.errors import IBMRemoteExecutionError
 
 Runtime_Service = None
 
@@ -158,7 +158,7 @@ def get_backend(device: IBMDevice) -> "BackendV2":
     parameter.
 
     Args:
-        device: The IBMDevice to get from IBMQ provider.
+        device: The IBMDevice to get from the qiskit Runtime service.
 
     Returns:
         The requested backend.
@@ -175,15 +175,15 @@ def get_backend(device: IBMDevice) -> "BackendV2":
 
     """
     if not device.is_remote():
-        raise ValueError("Expected a remote IBMQ device but got a local simulator.")
+        raise ValueError("Expected a remote IBM device but got a local simulator.")
     from qiskit.providers.exceptions import QiskitBackendNotFoundError
 
     service = get_QiskitRuntimeService()
 
     try:
         if device == IBMDevice.IBM_LEAST_BUSY:
             return service.least_busy(operational=True)
-        return service.get_backend(device.value)
+        return service.backend(device.value)
     except QiskitBackendNotFoundError as err:
         raise IBMRemoteExecutionError(
             f"Requested device {device} not found. Verify if your instances "
@@ -209,6 +209,5 @@ def get_all_job_ids() -> list[str]:
 
     """
     if get_env_variable("IBM_CONFIGURED") == "True":
-        return [job.job_id() for job in get_QiskitRuntimeService().jobs()]
-
+        return [job.job_id() for job in get_QiskitRuntimeService().jobs(limit=None)]
     return []

mpqp/execution/devices.py

@@ -104,24 +104,29 @@ class IBMDevice(AvailableDevice):
     AER_SIMULATOR_EXTENDED_STABILIZER = "extended_stabilizer"
     AER_SIMULATOR_MATRIX_PRODUCT_STATE = "matrix_product_state"
 
-    IBM_BRISBANE = "ibm_brisbane"
-    IBM_OSAKA = "ibm_osaka"
-    IBM_KYOTO = "ibm_kyoto"
-
     IBM_SHERBROOKE = "ibm_sherbrooke"
+    IBM_BRISBANE = "ibm_brisbane"
     IBM_KYIV = "ibm_kyiv"
-    IBM_NAZCA = "ibm_nazca"
-    IBM_CUSCO = "ibm_cusco"
-    IBM_ITHACA = "ibm_ithaca"
-    IBM_TORINO = "ibm_torino"
-    IBM_QUEBEC = "ibm_quebec"
+
+    IBM_FEZ = "ibm_fez"
+    IBM_RENSSELAER = "ibm_rensselaer"
+    IBM_BRUSSELS = "ibm_brussels"
     IBM_KAWASAKI = "ibm_kawasaki"
+    IBM_QUEBEC = "ibm_quebec"
+    IBM_TORINO = "ibm_torino"
+    IBM_NAZCA = "ibm_nazca"
+    IBM_STRASBOURG = "ibm_strasbourg"
+
+    # RETIRED - IBM_OSAKA = "ibm_osaka"
+    # RETIRED - IBM_KYOTO = "ibm_kyoto"
+    # RETIRED - IBM_CUSCO = "ibm_cusco"
+    # RETIRED - IBM_ITHACA = "ibm_ithaca"
     IBM_CLEVELAND = "ibm_cleveland"
-    IBM_CAIRO = "ibm_cairo"
-    IBM_HANOI = "ibm_hanoi"
-    IBM_ALGIERS = "ibm_algiers"
-    IBM_KOLKATA = "ibm_kolkata"
-    IBM_MUMBAI = "ibm_mumbai"
+    # RETIRED - IBM_CAIRO = "ibm_cairo"
+    # RETIRED - IBM_HANOI = "ibm_hanoi"
+    # RETIRED - IBM_ALGIERS = "ibm_algiers"
+    # RETIRED - IBM_KOLKATA = "ibm_kolkata"
+    # RETIRED - IBM_MUMBAI = "ibm_mumbai"
     IBM_PEEKSKILL = "ibm_peekskill"
 
     IBM_LEAST_BUSY = "ibm_least_busy"
@@ -131,7 +136,6 @@ def is_remote(self) -> bool:
 
     def is_gate_based(self) -> bool:
         return True
-        # return self != IBMDevice.PULSE_SIMULATOR
 
     def has_reduced_gate_set(self) -> bool:
         return self in {
@@ -163,15 +167,17 @@ def supports_state_vector(self) -> bool:
         }
 
     def supports_observable(self) -> bool:
-        return True
+        return self not in {
+            IBMDevice.AER_SIMULATOR_EXTENDED_STABILIZER,
+        }
 
     def supports_observable_ideal(self) -> bool:
         return self in {
             IBMDevice.AER_SIMULATOR,
             IBMDevice.AER_SIMULATOR_STATEVECTOR,
             IBMDevice.AER_SIMULATOR_DENSITY_MATRIX,
             IBMDevice.AER_SIMULATOR_STABILIZER,
-            IBMDevice.AER_SIMULATOR_EXTENDED_STABILIZER,
+            # IBMDevice.AER_SIMULATOR_EXTENDED_STABILIZER,
             IBMDevice.AER_SIMULATOR_MATRIX_PRODUCT_STATE,
         }