Adapted to breaking change in return type of Puppeteer.LaunchAsync

Author: stesee

Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj

@@ -39,7 +39,7 @@
 	<ItemGroup>
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
 		<PackageReference Include="PuppeteerSharp" Version="8.0.0" />
-		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.40.0.48530">
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.46.0.54807">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>

Codeuctivity.HtmlRenderer/Renderer.cs

@@ -21,7 +21,7 @@ public Renderer(string? launchOptions = null)
             LaunchOptions = launchOptions;
         }
 
-        private Browser Browser { get; set; } = default!;
+        private IBrowser Browser { get; set; } = default!;
         private int LastProgressValue { get; set; }
 
         /// <summary>
@@ -112,6 +112,8 @@ public async Task ConvertHtmlToPdf(string sourceHtmlFilePath, string destination
             var absolutePath = Path.GetFullPath(sourceHtmlFilePath);
             await using var page = (await Browser.NewPageAsync().ConfigureAwait(false));
             await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);
+            // Wait for fonts to be loaded. Omitting this might result in no text rendered in PDF.
+            await page.EvaluateExpressionHandleAsync("document.fonts.ready");
             await page.PdfAsync(destinationPdfFilePath).ConfigureAwait(false);
         }
 
@@ -130,6 +132,8 @@ public async Task ConvertHtmlToPng(string sourceHtmlFilePath, string destination
             var absolutePath = Path.GetFullPath(sourceHtmlFilePath);
             await using var page = (await Browser.NewPageAsync().ConfigureAwait(false));
             await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);
+            // Wait for fonts to be loaded. Omitting this might result in no text the screenshot.
+            await page.EvaluateExpressionHandleAsync("document.fonts.ready");
             await page.ScreenshotAsync(destinationPngFilePath, new ScreenshotOptions { FullPage = true }).ConfigureAwait(false);
         }
 

Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj

@@ -7,12 +7,12 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.40.0.48530">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.46.0.54807">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="xunit" Version="2.4.1" />
+    <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>

Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj

@@ -16,14 +16,14 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Codeuctivity.ImageSharpCompare" Version="2.0.61" />
+    <PackageReference Include="Codeuctivity.ImageSharpCompare" Version="2.0.76" />
     <PackageReference Include="Codeuctivity.PdfjsSharp" Version="1.2.47" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.40.0.48530">
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.46.0.54807">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
-    <PackageReference Include="xunit" Version="2.4.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
+    <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>