Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to custom environment variables trought /create #1588

Open
1 task done
Funasitien opened this issue Feb 18, 2025 · 3 comments
Open
1 task done

Add support to custom environment variables trought /create #1588

Funasitien opened this issue Feb 18, 2025 · 3 comments
Labels
in: node An issue/pull request releated to the node module code s: discussion This pull request or issue needs further internal discussion before merging t: feature request A request of a feature someone wants to see in a future release. v: 4.X This pull should be included in the 4.0 release

Comments

@Funasitien
Copy link

Describe the new feature

Add a new argument to the /create command : -env:VARIABLE_KEY VALUE to make possible to pass custom (env) variables when creating a service

Why do you need this feature?

To parse server owner, server names, ids, specific environment restrictions to a server uppon creation

Alternatives

Ability to use custom jvm options (like in v3) and use the -D magic to send custom values to the server (but a bit junky)

Other

No response

Issue uniqueness

  • Yes, this issue is unique. There are no similar issues.
@Funasitien Funasitien added s: needs triage Issue waiting for triage t: feature request A request of a feature someone wants to see in a future release. labels Feb 18, 2025
@0utplay
Copy link
Member

0utplay commented Feb 18, 2025

Why are the options in the task not enough for this?

@derklaro
Copy link
Member

I guess the real problem is not adding the option to the create command, it's that the environment variables need to be replaced (in other words: placeholder support) to get the values that you want - e.g. the actual server name.

@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code s: discussion This pull request or issue needs further internal discussion before merging and removed s: needs triage Issue waiting for triage labels Feb 18, 2025
@Funasitien
Copy link
Author

Funasitien commented Feb 18, 2025

Why are the options in the task not enough for this?

The idea is to be able to customize deployments trought commands. If you want to define a server owner, you can edit with this command the env variable to be the user that ran a custom command. It could be usefull for hosts, as it remove the need of a database which had to manage everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: node An issue/pull request releated to the node module code s: discussion This pull request or issue needs further internal discussion before merging t: feature request A request of a feature someone wants to see in a future release. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

No branches or pull requests

3 participants