Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer necessary val_unrolled_reduce workaround #20

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dennisYatunin
Copy link
Member

This PR removes the method for unrolled_reduce that specialized on a Val as its input (instead of specializing on an iterator), along with the underlying definition of val_unrolled_reduce.

This workaround was previously required to avoid long compilation times in three of the CPU tests for the non-orographic gravity wave parametrization in ClimaAtmos. Since CliMA/ClimaAtmos.jl#3313 has isolated the specific aspect of val_unrolled_reduce that was allowing us to avoid long compilation times, this non-standard implementation of unrolled_reduce is no longer necessary.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (5e77b08) to head (1cc30ad).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   59.19%   60.52%   +1.33%     
==========================================
  Files           7        7              
  Lines         272      266       -6     
==========================================
  Hits          161      161              
+ Misses        111      105       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisYatunin dennisYatunin merged commit d9273f3 into main Oct 23, 2024
11 checks passed
@dennisYatunin dennisYatunin deleted the dy/drop_val_hack branch October 23, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant