Remove no longer necessary val_unrolled_reduce workaround #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the method for
unrolled_reduce
that specialized on aVal
as its input (instead of specializing on an iterator), along with the underlying definition ofval_unrolled_reduce
.This workaround was previously required to avoid long compilation times in three of the CPU tests for the non-orographic gravity wave parametrization in ClimaAtmos. Since CliMA/ClimaAtmos.jl#3313 has isolated the specific aspect of
val_unrolled_reduce
that was allowing us to avoid long compilation times, this non-standard implementation ofunrolled_reduce
is no longer necessary.