Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatability with Custom Portals #167

Open
Sirfirelord1 opened this issue May 21, 2024 · 5 comments
Open

Compatability with Custom Portals #167

Sirfirelord1 opened this issue May 21, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Sirfirelord1
Copy link

Describe your idea

Allow the island builder to accept custom portals defined by https://www.curseforge.com/minecraft/mc-mods/custom-portal-api-reforged and https://www.curseforge.com/minecraft/mc-mods/custom-portal-builder as this would be great for modpack makers using custom nether portals instead of the vanilla obsidian one

@Sirfirelord1 Sirfirelord1 added the enhancement New feature or request label May 21, 2024
@MelanX
Copy link
Collaborator

MelanX commented May 21, 2024

Does that not work out of the box? I mean, these mods just add teleporting to other dimensions with custom portals, right?
SkyblockBuilder doesn't have its own dimension, it's the default overworld. If I'm wrong, I'm sorry.
Alternatively, I recently added a feature for custom nether portal. You could use this as well. You don't need to have a portal made with obsidian in this template, you just need a nether portal block present.

If I'm totally wrong with "out of the box", I'll look into adding compat. Maybe it's better than my own feature.

@Sirfirelord1
Copy link
Author

The specific mod I'm using (linked above) has its own "portal block" - its not the standard minecraft:nether_portal block, its something like customportalapi:portal_block (away from my PC atm but I'll get the exact block name tomorrow for you)
I'm quite a novice at modpack making, this is only my second modpack (and first skyblock) so it's quite possible that I've completely missed the functionality and this feature request is just me making a fool out of myself though. I'll send my config files tomorrow if you want to test it yourself, but i think it should be doable with a forge 1.20.1 instance running the two mods linked above + yours.

@MelanX
Copy link
Collaborator

MelanX commented May 21, 2024

Ahh ok. Yeah, configs would be cool since I have no idea about these mods. Before wasting my time finding out what to do, I'd like to have backup configs to use, thanks :)

@Sirfirelord1
Copy link
Author

Do you have a discord i can join? it might make things easier

@MelanX
Copy link
Collaborator

MelanX commented May 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants