Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split rate limitting between calibnet and mainnet #137

Open
2 tasks
LesnyRumcajs opened this issue Feb 5, 2025 · 0 comments · Fixed by #142
Open
2 tasks

Split rate limitting between calibnet and mainnet #137

LesnyRumcajs opened this issue Feb 5, 2025 · 0 comments · Fixed by #142
Assignees

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Feb 5, 2025

Summary

At the moment, there is a single rate limiter for both faucets. This means:

  • we cannot change drip time selectively, e.g., higher one for mainnet, lower for calibnet,
  • while the rate limiter blocks one, the other is also blocked.

Split the rate limiter into two, keeping in mind there might be more, and make the drip time configurable for faucets.

Completion Criteria

  • Each network faucet drip time can be configured separately,
  • Each network faucet is independent (rate-limit-wise) from the other.

Additional Links & Resources

I had to increase the drip time to 10 minutes in #137, but I would prefer to do it only for the mainnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants