-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented endorse post backend + Fixed Anon Refresh #34
Conversation
Pull Request Test Coverage Report for Build 13534500688Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Savannah, this looks great! I know this is a bug you've been working on for a long time, great work fixing it. I'll go ahead and check out from this branch after merging, and then add the endorse frontend.
Anonymous Refresh Fix: This new code fixes the bug that we have been working on with the anonymous refresh. The anonymous name would show up but upon refresh, everything would just revert back to the default settings. There was likely a database overriding that was happening due to the cascading nature of the database. The change was made, but it did not completely update in all parts of the database. Solution: Changed in post.tpl to check a boolean field rather than for a string field.
Endorse post backend: Started implementing the backend for the endorse feature. Because of the headache caused by creating a new field in the database for the anonymous reply feature, I decided to find a work around.
Anonymous Feature Working:

"Flagging" a post as "Endorsed by Admin", first click into the "⋮" menu and click "Flag this Post" then click on the "Endorsed by Admin" in the following screen.

Backend (in Admin dashboard) shows that the post is sucessfully "Endorsed by Admin"

To Dos:
Implement front end display of endorsed post on the top right of a post.
resolves #28 and #24