Enabled Topic Owners to properly delete posts in their topic

[jonassoh]

Context

Topic Owners could see the delete option on posts under their topic/thread but upon clicking the delete button, they would not have the permissions to delete and so the action would fail.

Description

Now, when a topic owner selects a post, the post will be marked as deleted and have all the attributes of a deleted post.

File Changes

src/socket.io/posts/tools.js
Updated the display permissions to display admin or moderator post options only if the user is an admin or moderator and not just if they have edit or delete permissions

src/privileges/posts.js
Under the privPosts.canDelete function, added a variable to check if the user is a topic owner and modified the flag to also be true if the user is the topic owner.

test/posts.js
Added set up and test case to see a topic Owner has the permission/privilege to delete posts under their topic.

Testing
Verified changes on the front end. Topic owner was able to successfully delete posts and did not have admin permissions.
Verified back end changes worked properly through test cases in test/posts.js

[RyanChernoff]

Your PR looks good but your code appears to be failing some of the lint tests. I would recommend making the changes suggested by the linter but otherwise looks good.

[coveralls]

Pull Request Test Coverage Report for Build 13557533598

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.01%) to 82.686%

---

Files with Coverage Reduction	New Missed Lines	%
src/posts/edit.js	4	94.74%

Totals
Change from base Build 13271607482:	0.01%
Covered Lines:	22345
Relevant Lines:	25605

---

💛 - Coveralls

[RyanChernoff]

Looks good now that the lint errors were fixed

[rmurugan58]

The PR looks good. The only thing I would check is the merge conflict still present in nodebb-theme-harmony/templates/topic.tpl. Besides this, the code looks good, and all lint tests are passing, so it looks ready to go.

[rmurugan58]

Now that the merge conflicts are resolved, everything looks good!