-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resolved/Unresolved Functionality to Topics #14
Conversation
…unresolved questions, added unit + integration tests for api
…s order to pass PR tests
…lers/topics.js and test/topics.js order to pass PR tests
… to pass PR Linter Tests
…aml to pass node tests for PR merge
Great work on adding the resolved/unresolved functionality! 🚀 |
The PR description is very well-defined. There are proper API designs and database schema updates that are persistent, queryable, and optimized. Additionally, there are appropriate units and integration tests that cover edge cases and ensure code quality and correctness. Overall, every features look great! |
Amazing work!! Just ran through the test suite and it looks great. Excellent code changes that are clear, uniform, and correct. Tests are thorough and successful! LGTM :) |
📝 Context
✅ Changes in the Codebase
src/routes/api.js
topics/:tid/resolved
route (end of file)src/controllers/topics.js
setResolved()
function to update the topic status (end of file)src/api/topics.js
setResolved()
function to flip resolved boolean status in Redis (end of file)resolved
fieldsrc/topics/create.js
andpublic/openapi/components/schemas/TopicObject.yaml
resolved
field (default is false) to topics data (beginning of file)test/topics.js