Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4 Build homepage for app #13

Closed
wants to merge 16 commits into from
Closed

#4 Build homepage for app #13

wants to merge 16 commits into from

Conversation

orimdominic
Copy link

@orimdominic orimdominic commented May 22, 2020 •
edited
Loading

Description

A registered/unregistered user should be able to land on a homepage

New dependencies

  • materialize-css

This PR fixes #4

Screenshots

homepage-responsive

How should this be manually tested?

  • Get this branch to local with git fetch upstream
  • Run git checkout upstream/homepage-responsive on your terminal
  • Install dependencies npm install
  • Run the app npm start

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • New and existing unit tests pass locally with my changes

Extra notes

  • We'll need to discuss the exact text and links to add to the page on slack or any other workgroup channel

RuthChisom
RuthChisom previously approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@RuthChisom RuthChisom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

nues007
nues007 previously approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@nues007 nues007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking Good

@orimdominic orimdominic dismissed stale reviews from nues007 and RuthChisom via 3a6cbda May 22, 2020 09:36
@orimdominic orimdominic requested a review from nues007 May 22, 2020 09:38
@orimdominic orimdominic changed the title Feat/homepage responsive #4 Build homepage for app May 22, 2020
nues007
nues007 approved these changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@nues007 nues007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good
but i believe the page should have more items for sale

@orimdominic
Copy link
Author

looking good
but i believe the page should have more items for sale

It is not the landing page. It is the home page.
A modification may be to add a link to the markets page
What do you think?

@orimdominic orimdominic deleted the feat/homepage-responsive branch May 24, 2020 01:20
@orimdominic orimdominic mentioned this pull request Jun 3, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nues007 nues007 nues007 approved these changes

@RuthChisom RuthChisom RuthChisom left review comments

@torsami77 torsami77 Awaiting requested review from torsami77

@Biosmatrix Biosmatrix Awaiting requested review from Biosmatrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Homepage
3 participants
@orimdominic @nues007 @RuthChisom