importing wizard.scss causes rem & px issues

[chrisbbreuer]

Hi there,

I need to manually pull in and compile wizard.scss but with Bootstrap 4 there are issues:

 Module build failed: ModuleBuildError: Module build failed:
 $input-height-base:              ($line-height-computed + ($padding-base-vertical * 2) + 2) !default;
                                 ^
  Incompatible units: 'px' and 'rem'.

I fixed it by changing the affected variables from px to the rem "equivalent", but I am not certain whether that's the correct approach as I am not too familiar here?

If that's the correct approach, I am more than welcome to send in a PR.

Any tips would be appreciated on how to best handle this.

Chris

edit: check out my commit, and tell me whether this should be pushed or not. :-)

[cristijora]

Hi @chris1904 You can always import the compiled css file to avoid such issues.
Regarding the fix, the appropriate fix would be to prefix the sass variables with something like vfw- so they don't conflict with bootstrap ones.