Merge pull request pact-foundation#155 from iamvery/quote-path-to-support-spaces

fix: escape --pact-helper CLI option

Author: bethesque

lib/pact/tasks/task_helper.rb

@@ -26,7 +26,7 @@ def verify_command pact_helper, pact_uri, rspec_opts
       command_parts << "SPEC_OPTS=#{Shellwords.escape(rspec_opts || '')}"
       command_parts << FileUtils::RUBY
       command_parts << "-S pact verify"
-      command_parts << "--pact-helper" << (pact_helper.end_with?(".rb") ? pact_helper : pact_helper + ".rb")
+      command_parts << "--pact-helper" << Shellwords.escape(pact_helper.end_with?(".rb") ? pact_helper : pact_helper + ".rb")
       (command_parts << "--pact-uri" << pact_uri) if pact_uri
       command_parts << "--pact-broker-username" << ENV['PACT_BROKER_USERNAME'] if ENV['PACT_BROKER_USERNAME']
       command_parts << "--pact-broker-password" << ENV['PACT_BROKER_PASSWORD'] if ENV['PACT_BROKER_PASSWORD']
@@ -53,4 +53,4 @@ def temporarily_set_env_var name, value
       ENV[name] = original_value
     end
   end
-end
+end

spec/lib/pact/tasks/task_helper_spec.rb

@@ -90,6 +90,16 @@ module Pact
         end
       end
 
+      context "with a pact_helper with whitespace in its path" do
+        let(:custom_pact_helper_path) { '/path/to the/pact_helper.rb' }
+        let(:escaped_custom_pact_helper_path) { '/path/to\\ the/pact_helper.rb' }
+        let(:command) { "SPEC_OPTS='' #{ruby_path} -S pact verify --pact-helper #{escaped_custom_pact_helper_path} --pact-uri #{pact_uri}" }
+        it "executes the command" do
+          expect(TaskHelper).to receive(:execute_cmd).with(command)
+          TaskHelper.execute_pact_verify(pact_uri, custom_pact_helper_path)
+        end
+      end
+
       context "with a pact_helper with no .rb on the end" do
         let(:custom_pact_helper_path) { '/custom/pact_helper' }
         let(:command) { "SPEC_OPTS='' #{ruby_path} -S pact verify --pact-helper #{custom_pact_helper_path}.rb --pact-uri #{pact_uri}" }